summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | rm redundant code: SetNextFile has already been called before in this functionEric Wang2021-12-051-1/+0
| | | | | | | | | |
* | | | | | | | | | VersionSet::Builder::Apply() does not mutate its argument.Victor Costan2022-01-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420533763
* | | | | | | | | | Merge pull request #903 from LazyWolfLin:dev_randomVictor Costan2022-01-091-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420532625
| * | | | | | | | | | Small fix.LazyWolfLin2021-05-111-1/+1
| | |_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Use function instead of original expression.
* | | | | | | | | | Merge pull request #902 from ehds:update-table-cacheVictor Costan2022-01-091-0/+4
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420517390
| * | | | | | | | | | Make table cache non-copyableehds2021-05-081-0/+4
| |/ / / / / / / / /
* | | | | | | | | | Merge pull request #965 from ShawnZhong:cpp20Victor Costan2022-01-082-4/+4
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420504266
| * | | | | | | | | | Update env_posix.ccShawn Zhong2021-12-301-2/+2
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #967 from rex4539:typosVictor Costan2022-01-083-4/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420403341
| * | | | | | | | | | | Fix typosDimitris Apostolou2022-01-053-4/+4
| | | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #968 from xindubawukong:dxy_remove_codeVictor Costan2022-01-081-8/+0
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420399272
| * | | | | | | | | | | remove useless code in cache.hxindubawukong2022-01-061-8/+0
| |/ / / / / / / / / /
* | | | | | | | | | | Remove main() from most tests.Victor Costan2022-01-0329-174/+54
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives some flexibility to embedders. Currently, embedders have to build a binary for each test file. After this CL, embedders can still choose to have a binary for each test file, by linking each test file with a googletest target that includes main() (usually "gtest_main"). Embedders can also choose to build a single binary for almost all test files, and link with a googletest target that includes main(). The latter is more convenient for projects that have very few test binaries, like Chromium. PiperOrigin-RevId: 419470798
* | | | | | | | | | Extract benchmark from db_test.cc.Victor Costan2021-12-293-71/+99
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The benchmark in db/db_test.cc is extracted to its own file, benchmarks/db_bench_log.cc. PiperOrigin-RevId: 418713499
* | | | | | | | | | Add invariant checks to Limiter in Env implementations.Victor Costan2021-12-222-5/+52
| |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 417853172
* | | | | | | | | Merge pull request #941 from pmmp:no-handle-inheritanceVictor Costan2021-11-301-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 412997201
| * | | | | | | | | Prevent handle used for LOG from being inherited by subprocessesDylan K. Taylor2021-10-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I recently encountered a problem with this because Windows doesn't allow files to be deleted when there's open handles to them. Other files opened by leveldb are not affected because by and large they are using CreateFileA, which does not allow inheritance when lpSecurityAttributes is null (ref: https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea) However, fopen() _does_ allow inheritance, and it needs to be expressly disabled. https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160
* | | | | | | | | | Merge pull request #951 from philix:no_pthreadVictor Costan2021-11-291-1/+0
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 412965575
| * | | | | | | | | Remove <pthread.h> include and find_package() from build filesFelipe Oliveira Carvalho2021-11-281-1/+0
|/ / / / / / / / /
* | | | | | | | | Get env_posix.cc building under Fuchsia.leveldb Team2021-09-121-0/+7
| |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 395824737
* | | | | | | | Switch CI to GitHub Actions.Victor Costan2021-09-024-126/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 394542401
* | | | | | | | Remove the `/` prefix from the recovery_test test file to prevent a double `/`.leveldb Team2021-08-031-1/+1
| |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 388341429
* | | | | | | Update Travis CI config.Victor Costan2021-05-251-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Xcode (drives macOS image) : 12.2 => 12.5 Clang : 10 => 12 GCC : 10 => 11 PiperOrigin-RevId: 375582717
* | | | | | | Merge pull request #906 from pwnall/third-party-bumpVictor Costan2021-05-242-0/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Roll third-party dependencies.
| * | | | | | | Roll third-party dependencies.Victor Costan2021-05-172-0/+0
| | |/ / / / / | |/| | | | |
* | | | | | | Fix compactions that could end up breaking a run of the same userSanjay Ghemawat2021-05-201-0/+2
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | key across multiple files. As reported in Github issue #339, it is incorrect to split the same user key across multiple compacted files since it causes tombstones/newer-versions to be dropped, thereby exposing obsolete data. There was a fix for #339, but it ended up not fully fixing the problem. (It checked for boundary problems in the first level being compacted, but not the second). This problem was revealed by Github issue 887. We now adjust boundaries to avoid splitting user keys in both the first level and the second level. PiperOrigin-RevId: 374921082
* | | | | | Merge pull request #881 from firebase:apple-toolchain-fixesVictor Costan2021-03-041-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 360972284
| * | | | | | Don't include C++ headers in extern CPaul Beusterien2021-03-031-4/+4
|/ / / / / /
* | | | | | Change version to 1.23.1.23Chris Mumford2021-02-232-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 359111035
* | | | | | Fix fprintf format string.Chris Mumford2021-02-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using %zu for size_t instead of %ld. PiperOrigin-RevId: 357976882
* | | | | | Use partial path to benchmark/benchmark.h.Chris Mumford2021-02-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the partial path offers more flexibility to projects which may checkout google/benchmark to a different location. PiperOrigin-RevId: 357819911
* | | | | | IWYU fixes in db/c.cc.Victor Costan2021-01-251-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/google/leveldb/issues/872 PiperOrigin-RevId: 353657701
* | | | | | Fix build errors.Victor Costan2021-01-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 351442409
* | | | | | Sync MANIFEST before closing in db_impl when creating a new DB.leveldb Team2021-01-122-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add logging with debugging information when failing to load a version set. PiperOrigin-RevId: 351432332
* | | | | | Optimize leveldb block seeks to utilize the current iterator location.leveldb Team2021-01-113-35/+221
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is beneficial when iterators are reused and seeks are not random but increasing. It is additionally beneficial with larger block sizes and keys with common prefixes. Add a benchmark "seekordered" to db_bench that reuses iterators across increasing seeks. Add support to the benchmark to count comparisons made and to support common key prefix length. Change benchmark random seeds to be reproducible for entire benchmark suite executions but unique for threads in different benchmarks runs. This changes a benchmark suite of readrandom,seekrandom from having a 100% found ratio as previously it had the same seed used for fillrandom. ./db_bench --benchmarks=fillrandom,compact,seekordered --block_size=262144 --comparisons=1 --key_prefix=100 without this change (though with benchmark changes): seekrandom : 55.309 micros/op; (631820 of 1000000 found) Comparisons: 27001049 seekordered : 1.732 micros/op; (631882 of 1000000 found) Comparisons: 26998402 with this change: seekrandom : 55.866 micros/op; (631820 of 1000000 found) Comparisons: 26952143 seekordered : 1.686 micros/op; (631882 of 1000000 found) Comparisons: 25549369 For ordered seeking, this is a reduction of 5% comparisons and a 3% speedup. For random seeking (with single use iterators) the comparisons and speed are less than 1% and likely noise. PiperOrigin-RevId: 351149832
* | | | | | Merge pull request #862 from rex4539:httpsVictor Costan2021-01-014-8/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 349711809
| * | | | | | Fix insecure linksDimitris Apostolou2020-12-194-8/+8
|/ / / / / /
* | | | | | Update Travis CI config.Victor Costan2020-12-141-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 347391876
* | | | | | Merge pull request #855 from cmumford/submodule-fixVictor Costan2020-11-301-0/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixup for adding the third_party/benchmark submodule.
| * | | | | | Fixup for adding the third_party/benchmark submodule.Chris Mumford2020-11-301-0/+0
|/ / / / / /
* | | | | | Merge pull request #853 from cmumford:benchmarkChris Mumford2020-11-302-1/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 344909677
| * | | | | | Added google/benchmark submodule.Chris Mumford2020-11-303-1/+6
| | | | | | |
* | | | | | | Merge pull request #854 from cmumford:printf-fixChris Mumford2020-11-301-1/+3
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | PiperOrigin-RevId: 344871226
| * | | | | | Fixed fprintf of 64-bit value.Chris Mumford2020-11-301-1/+3
|/ / / / / /
* | | | | | Fix bug in filter policy documentation example.Sanjay Ghemawat2020-11-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 344817715
* | | | | | Use external benchmark API headerleveldb Team2020-11-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 339310928
* | | | | | Internal test cleanupleveldb Team2020-11-301-12/+9
| | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 339287832
* | | | | | Internal cleanup migrating StatusOr.leveldb Team2020-10-071-1/+1
|/ / / / / | | | | | | | | | | | | | | | PiperOrigin-RevId: 329720018
* | | | | Merge pull request #822 from jl0x61:bugFixChris Mumford2020-07-151-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 321372819
| * | | | | update index.mdjl0x612020-07-141-1/+1
|/ / / / / | | | | | | | | | | | | | | | remove return value of GetApproximateSizes in index.md