summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* leveldb: Check slice length in Footer::DecodeFrom()HEADmainleveldb Team2023-04-201-0/+4
| | | | | | | | | | | Without this check decoding the footer in Table::Open() can read uninitialized bytes from a buffer allocated on the stack if the file was unexpectedly short. In practice this is probably fine since this function validates a magic number but MSan complains about branching on uninitialized data. PiperOrigin-RevId: 525271012
* Support Zstd compression level in Leveldbleveldb Team2023-04-206-6/+30
| | | | PiperOrigin-RevId: 520556840
* Fix GitHub CI on Linux.Victor Costan2023-03-281-2/+3
| | | | | | | | | This PR temporarily removes a package that is currently broken on GitHub's Ubuntu 22.04 installation. This is the most expedient way to make the CI green again, so we can test any other changes we may want to land. PiperOrigin-RevId: 520206940
* Merge pull request #1104 from reillyeon:chromium_envVictor Costan2023-03-283-0/+21
|\ | | | | | | PiperOrigin-RevId: 520172744
| * Address comments.Reilly Grant2023-03-282-17/+13
| |
| * Fix tests when run against ChromiumEnvReilly Grant2023-03-283-11/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a couple differences between ChromiumEnv and PosixEnv/WindowsEnv which cause test failures that are fixed (or at least patched over) in this change: * NewSequentialFile() and NewRandomAccessFile() return Status::IOError rather than Status::NotFound when a file is not found, due to https://crbug.com/760362. This means a few tests need to expect a different error result. * GetChildren() never returns the '.' or '..' entries. * As allowed by the documentation for Env::Schedule(), ChromiumEnv may execute functions on multiple threads and guarantees no sequencing. EnvTest.RunMany assumed that functions ran in order. The test has been updated.
* | Merge pull request #1106 from reillyeon:run_manyVictor Costan2023-03-281-11/+16
|\ \ | | | | | | | | | PiperOrigin-RevId: 520171344
| * | Fix EnvTest.RunMany to allow parallel executionReilly Grant2023-03-281-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | As allowed by the documentation for Env::Schedule(), ChromiumEnv may execute functions on multiple threads and guarantees no sequencing. EnvTest.RunMany assumed that functions ran in order, is the case for the stock PosixEnv and WindowsEnv implementations. This change updates the test to not assume sequential execution.
* | | Add support for Zstd-based compression in LevelDB.leveldb Team2023-03-2810-53/+224
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change implements support for Zstd-based compression in LevelDB. Building up from the Snappy compression (which has been supported since inception), this change adds Zstd as an alternate compression algorithm. We are implementing this to provide alternative options for users who might have different performance and efficiency requirements. For instance, the Zstandard website (https://facebook.github.io/zstd/) claims that the Zstd algorithm can achieve around 30% higher compression ratios than Snappy, with relatively smaller (~10%) slowdowns in de/compression speeds. Benchmarking results: $ blaze-bin/third_party/leveldb/db_bench LevelDB: version 1.23 Date: Thu Feb 2 18:50:06 2023 CPU: 56 * Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz CPUCache: 35840 KB Keys: 16 bytes each Values: 100 bytes each (50 bytes after compression) Entries: 1000000 RawSize: 110.6 MB (estimated) FileSize: 62.9 MB (estimated) ------------------------------------------------ fillseq : 2.613 micros/op; 42.3 MB/s fillsync : 3924.432 micros/op; 0.0 MB/s (1000 ops) fillrandom : 3.609 micros/op; 30.7 MB/s overwrite : 4.508 micros/op; 24.5 MB/s readrandom : 6.136 micros/op; (864322 of 1000000 found) readrandom : 5.446 micros/op; (864083 of 1000000 found) readseq : 0.180 micros/op; 613.3 MB/s readreverse : 0.321 micros/op; 344.7 MB/s compact : 827043.000 micros/op; readrandom : 4.603 micros/op; (864105 of 1000000 found) readseq : 0.169 micros/op; 656.3 MB/s readreverse : 0.315 micros/op; 350.8 MB/s fill100K : 854.009 micros/op; 111.7 MB/s (1000 ops) crc32c : 1.227 micros/op; 3184.0 MB/s (4K per op) snappycomp : 3.610 micros/op; 1081.9 MB/s (output: 55.2%) snappyuncomp : 0.691 micros/op; 5656.3 MB/s zstdcomp : 15.731 micros/op; 248.3 MB/s (output: 44.1%) zstduncomp : 4.218 micros/op; 926.2 MB/s PiperOrigin-RevId: 509957778
* | Roll third_party/benchmark to f7547e29ccaed7b64ef4f7495ecfff1c9f6f3d03Reilly Grant2023-03-281-0/+0
|/ | | | Fixes an unused variable warning.
* Stop future writes if a log file Close() fails.Sanjay Ghemawat2023-01-042-6/+77
| | | | | | See https://github.com/google/leveldb/issues/1081 PiperOrigin-RevId: 499519182
* Fix maintenance textleveldb Team2022-07-181-1/+1
| | | | PiperOrigin-RevId: 461725664
* Fix Markdown formatting in README.Victor Costan2022-07-181-1/+1
| | | | PiperOrigin-RevId: 461722304
* Add note on current development stateleveldb Team2022-07-181-1/+11
| | | | PiperOrigin-RevId: 461695246
* Merge pull request #1036 from chjj:benchmark-compressionVictor Costan2022-07-181-0/+8
|\ | | | | | | PiperOrigin-RevId: 461612590
| * Add compression flag to benchmarks.Christopher Jeffrey2022-06-191-0/+8
| |
* | Use GTEST_SKIP in leveldb:table_testleveldb Team2022-07-181-4/+2
| | | | | | | | | | | | This replaces a usage of fprintf to stderr PiperOrigin-RevId: 454620969
* | Merge pull request #1008 from pkasting:mainVictor Costan2022-05-091-2/+0
|\ \ | |/ |/| | | PiperOrigin-RevId: 447466466
| * Fixes for C++20 support.Peter Kasting2022-05-051-2/+0
|/ | | | | | | Structs with user-declared constructors are no longer considered aggregates. Just remove the constructor declaration where applicable. Bug: chromium:1284275
* The master branch was renamed to main.masterVictor Costan2022-01-172-5/+5
| | | | PiperOrigin-RevId: 422409116
* Update contributing guidelines.Victor Costan2022-01-112-27/+28
| | | | | | | * Align CONTRIBUTING.md with the google/new-project template. * Explain the support story for the CMake config. PiperOrigin-RevId: 421120645
* Merge pull request #506 from lingbin:fix_issue_505Victor Costan2022-01-101-10/+0
|\ | | | | | | PiperOrigin-RevId: 420787858
| * Merge branch 'master' into fix_issue_505Victor Costan2022-01-10156-7611/+9575
| |\
| * | fix style and remove unused codelingbin2017-09-042-12/+2
| | |
* | | Merge pull request #893 from myccccccc:masterVictor Costan2022-01-101-2/+0
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 420783873
| * | | delete an unnecessary forward declarationmayingchun2021-04-051-2/+0
| | | |
* | | | Merge pull request #888 from JayiceZ:fix_typoVictor Costan2022-01-101-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 420783487
| * | | | fix typo in port_example.hJayice2021-03-281-1/+1
| |/ / /
* | | | Merge pull request #652 from caodhuan:masterVictor Costan2022-01-101-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 420782536
| * | | | add:compact_pointers_ should be clear when Clear() calledcaodhuan2019-01-221-0/+1
| | | | |
* | | | | Merge pull request #744 from HenryRLee:patch-1Victor Costan2022-01-101-2/+0
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420781374
| * \ \ \ \ Merge branch 'master' into patch-1Victor Costan2022-01-09112-1861/+1951
| |\ \ \ \ \ | | | |_|_|/ | | |/| | |
| * | | | | Remove unused variable kDelayMicros in env_test.ccHenry Lee2019-10-151-2/+0
| | | | | |
* | | | | | Merge pull request #602 from andyli029:feature_fix_lack_tag_commentVictor Costan2022-01-101-0/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420781095
| * | | | | | lack of sequence and type in comments to introduce entry formatandy2018-06-281-0/+1
| | | | | | |
* | | | | | | Merge pull request #747 from zltl:patch-1Victor Costan2022-01-101-1/+1
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | PiperOrigin-RevId: 420778907
| * | | | | | fix typo in comment of LRUHandleLiao Tonglang2019-10-221-1/+1
| | |/ / / / | |/| | | | | | | | | | LRUHandle has no member "next_", fix it to "next" instead.
* | | | | | Merge pull request #901 from mapleFU:opt-using-moveVictor Costan2022-01-101-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420662938
| * | | | | | [Init] initial commitmwish2021-05-021-1/+1
| | |_|_|/ / | |/| | | |
* | | | | | Merge pull request #897 from raynolmenezes:patch-1Victor Costan2022-01-101-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420662891
| * | | | | | Update log_reader.hRaynol Menezes2021-04-161-1/+1
| |/ / / / /
* | | | | | Merge pull request #945 from xiong-ang:masterVictor Costan2022-01-101-5/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420645727
| * | | | | | fix some trifling points xiong-ang2021-10-221-6/+7
| | | | | | |
* | | | | | | Merge pull request #934 from BilyZ98:masterVictor Costan2022-01-101-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420645080
| * | | | | | | Fix version_set.cc comments typozzt2021-09-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fix typo of comment of FindLargestKey function
* | | | | | | | Merge pull request #919 from wineway:fix_posix_testVictor Costan2022-01-101-3/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420644954
| * | | | | | | | fixed random access file exhaust random mmap file use wrong limit countwineway2021-07-011-3/+3
| | | | | | | | |
* | | | | | | | | Merge pull request #928 from ehds:fix-commentVictor Costan2022-01-091-3/+3
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420541137
| * | | | | | | | | Fix comments positionehds2021-08-081-3/+3
| |/ / / / / / / /
* | | | | | | | | Merge pull request #960 from ericuni:dedupVictor Costan2022-01-091-1/+0
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 420534594