summaryrefslogtreecommitdiff
path: root/tar
diff options
context:
space:
mode:
authorNgie Cooper <yanegomi@gmail.com>2016-12-10 16:24:35 -0800
committerNgie Cooper <yanegomi@gmail.com>2016-12-10 16:24:35 -0800
commitf1b1881dfed9e8f4b2487aa74f6d151b1047539f (patch)
tree9f652f700443b3b9335b3c1bf89c00635fc8ed5f /tar
parente08543094231b9b209a5f0a48e87520a3083a011 (diff)
downloadlibarchive-f1b1881dfed9e8f4b2487aa74f6d151b1047539f.tar.gz
Don't leak the file descriptor pointed to by `in` if the first call to
fgets fails. Reported by: Coverity CID: 1331677
Diffstat (limited to 'tar')
-rw-r--r--tar/test/main.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/tar/test/main.c b/tar/test/main.c
index 6bc35578..9bb7964c 100644
--- a/tar/test/main.c
+++ b/tar/test/main.c
@@ -2324,7 +2324,7 @@ extract_reference_file(const char *name)
for (;;) {
if (fgets(buff, sizeof(buff), in) == NULL) {
/* TODO: This is a failure. */
- return;
+ goto done;
}
if (memcmp(buff, "begin ", 6) == 0)
break;
@@ -2365,6 +2365,7 @@ extract_reference_file(const char *name)
}
}
fclose(out);
+done:
fclose(in);
}