| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clang 16 introduced a warning about single bit bitfields in structs,
which is triggered by a few libarchive formats:
libarchive/archive_write_set_format_7zip.c:1541:13: error: implicit
truncation from 'int' to a one-bit wide bit-field changes value from 1
to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
file->dir = 1;
^ ~
This is because single bit bitfields only support values -1 and 0, if
they are signed.
For bitfields with two or more bits this can be intentional, but single
bit bitfields are typically used as booleans, so it is better to make
them unsigned.
|
|
|
|
|
|
|
|
|
| |
Otherwise there are 32/64-bit pointer conversions going on. In Windows
since MSVC2005, time_t has been 64-bit. MinGW needs a hack to get 64-bit
time_t.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
|
|
| |
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
| |
|
| |
|
|
|
|
|
|
|
| |
Remove rbtree nodes before freeing them.
For better code readability import new rbtree macros from NetBSD.
Fixes #1325
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
archive_read_support_format_rar5.c:
Bitfield int -> signed int
Archive_write_set_format_iso9660.c:
Bitfield int -> signed int
archive_write_set_format_xar.c:
Bitfield int -> signed int
archive_write_set_format_7zip.c:
Bitfield int -> signed int
archive_read_support_format_xar.c
Remove useless comparsion
archive_read_support_format_rar.c:
Fix invalid nested loop break.
Comment out dead code sections.
Simplify size comparsions of lensymbol and offsymbol.
archive_read_support_filter_uu.c:
Remove useless comparsions
archive_read_disk_posix.c:
Remove useless do-while-zero
Found by LGTM.com code analysis
|
| |
|
|
|
|
| |
Per Coverity report.
|
|
|
|
| |
Add a dedicated `{}` block to contain a local variable instead.
|
|\
| |
| | |
Fix coverity issues with libarchive/
|
| |
| |
| |
| |
| |
| |
| | |
value to (int)
Reported by: Coverity
CID: 1017786
|
|/ |
|
|
|
|
| |
Sponsored by: Tarsnap Backup Inc.
|
|
|
| |
Sponsored by: Tarsnap Backup Inc.
|
|
|
|
| |
Sponsored by: Tarsnap Backup Inc.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
ISO9660 archives
* Don't cast size_t to int, since this can lead to overflow
on machines where sizeof(int) < sizeof(size_t)
* Check a + b > limit by writing it as
a > limit || b > limit || a + b > limit
to avoid problems when a + b wraps around.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Do not assign the return value of realloc into the variable that has
the original pointer because if realloc failed we will lose the chance
to release the address.
|
|
|
|
|
|
| |
archive_strcpy_in_locale ==> archive_strcpy_l
archive_strncpy_in_locale ==> archive_strncpy_l
archive_strncat_in_locale ==> archive_strncat_l
|
| |
|
|
|
|
| |
to 'type2', possible lose of data.
|
|
|
|
| |
Properly set a clear error message when archive_{write,read}_set_options failed.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
archive_string_append_from_mbs,
those function should report the error to the caller instead of invoking __archive_errx().
We should report that ENOMEM error as possible as we can and we still need to further
improve reporting ENOEM.
SVN-Revision: 4193
|
|
|
|
|
|
|
| |
The PGI compiler confuses parameter name "isoent" with "struct isoent".
Rename the parameter to "curent" to avoid confusion.
SVN-Revision: 4136
|
|
|
|
|
|
| |
The LL suffix is not portable. Use an explicit cast instead.
SVN-Revision: 4127
|
|
|
|
| |
SVN-Revision: 4092
|
|
|
|
| |
SVN-Revision: 3993
|
|
|
|
| |
SVN-Revision: 3795
|
|
|
|
|
|
| |
which some C compiler complain about.
SVN-Revision: 3710
|
|
|
|
| |
SVN-Revision: 3667
|
|
|
|
|
|
|
|
|
| |
file tree
which file has the same name; it is better that front-end applications such as tar decide
how they handle that case.
SVN-Revision: 3480
|
|
|
|
|
|
| |
such as "." , "/" or "../" and fix that handling. This is to improve r3464 changes.
SVN-Revision: 3466
|
|
|
|
|
|
| |
exactly "." which is the same as the root directory name of an ISO image.
SVN-Revision: 3464
|
|
|
|
|
|
| |
how many components are stripped or renaming a part of path names they like.
SVN-Revision: 3463
|
|
|
|
|
|
| |
the temporary file.
SVN-Revision: 3462
|
|
|
|
| |
SVN-Revision: 3411
|
|
|
|
| |
SVN-Revision: 3409
|
|
|
|
|
|
|
|
|
| |
in the iso9660 writer.
- Stop reading the contents of each file from the temporary file with read().
- Read the block of all file contents instead, and then write it to next stream.
SVN-Revision: 3407
|
|
|
|
| |
SVN-Revision: 3406
|
|
|
|
|
|
|
|
|
|
|
| |
the iso9660 writer.
- Copy file contents to wbuff, 64K buffer, and then write wbuff data with write() syscall when
the buffer is full.
- Improve wbuff handling to be able to be used for zisofs accordingly.
- Stop using wbuff as read buffer in setup_boot_information() function.
SVN-Revision: 3405
|
|
|
|
|
|
|
|
|
|
|
| |
the iso9660 writer.
- Use only one temporary file to be simple structure.
- When enabling zisofs, almost all files except a small(<2048 bytes) file are, consequently,
always compressed even if it is a boot file. The boot file will be uncompressed later.
- Write those files to the temporary file by 2048 bytes, though currently this is no effect.
SVN-Revision: 3404
|