diff options
author | Pete Zaitcev <zaitcev@kotori.zaitcev.us> | 2019-02-12 18:13:01 -0600 |
---|---|---|
committer | Pete Zaitcev <zaitcev@kotori.zaitcev.us> | 2019-02-13 00:46:52 -0600 |
commit | 3564b711b4e543dc361444159ff9f7fb331eaad6 (patch) | |
tree | 9f1b9da4207ed33843fd6c0da887188e278c1d32 /src/erasurecode_helpers.c | |
parent | 405775cba1d1ac06b86b2fab64e8f9d03ab2fd0e (diff) | |
download | liberasurecode-3564b711b4e543dc361444159ff9f7fb331eaad6.tar.gz |
Remove get_chksum to hush warnings
This popped up because Fedora mandates warning-free builds,
and get_chksum triggers a warning because it returns an
unaligned pointer (it is so analigned, static analysis in
the compiler can detect it).
The easiest fix is to remove it altogether. We think it should
be safe, because:
- The function is not listed in any headers
- Its counterpart is called "set_checksum", not "set_chksum"
- PyECLib does not use it
We also hush some doxygen warnings about wrong comments.
Change-Id: Ie5bc736f912706e0ffd507765abd24e7f4761233
Diffstat (limited to 'src/erasurecode_helpers.c')
-rw-r--r-- | src/erasurecode_helpers.c | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/src/erasurecode_helpers.c b/src/erasurecode_helpers.c index 1494587..4be2634 100644 --- a/src/erasurecode_helpers.c +++ b/src/erasurecode_helpers.c @@ -178,8 +178,8 @@ uint64_t get_fragment_size(char *buf) * Compute a size aligned to the number of data and the underlying wordsize * of the EC algorithm. * - * @param instance, ec_backend_t instance (to extract args) - * @param data_len, integer length of data in bytes + * @param instance - ec_backend_t instance (to extract args) + * @param data_len - integer length of data in bytes * @return integer data length aligned with wordsize of EC algorithm */ int get_aligned_data_size(ec_backend_t instance, int data_len) @@ -487,17 +487,4 @@ inline int set_checksum(ec_checksum_type_t ct, char *buf, int blocksize) return 0; } -inline uint32_t* get_chksum(char *buf) -{ - fragment_header_t* header = (fragment_header_t*) buf; - - assert(NULL != header); - if (header->magic != LIBERASURECODE_FRAG_HEADER_MAGIC) { - log_error("Invalid fragment header (get chksum)!"); - return NULL; - } - - return (uint32_t *) header->meta.chksum; -} - /* ==~=*=~==~=*=~==~=*=~==~=*=~==~=*=~==~=*=~==~=*=~==~=*=~==~=*=~==~=*=~== */ |