diff options
| author | Tim Burke <tim.burke@gmail.com> | 2020-07-01 21:59:45 -0700 |
|---|---|---|
| committer | Tim Burke <tim.burke@gmail.com> | 2020-09-30 16:38:11 -0700 |
| commit | 5626cd5791bd35279594e067c10581e89ae66abc (patch) | |
| tree | dc097ab19dd71e9b4866ed792373d673e900b808 /test | |
| parent | fb13b37506088aec05013dc05e7fc0e6aee49f09 (diff) | |
| download | liberasurecode-5626cd5791bd35279594e067c10581e89ae66abc.tar.gz | |
Be willing to write fragments with legacy crc
...if users *really* want to. They opt-in at run time by setting
LIBERASURECODE_WRITE_LEGACY_CRC=1
in the environment; leaving it unset, set to an empty string, or set to
the string "0" continues to write zlib crcs.
UpgradeImpact
=============
This option is intended to allow a smooth upgrade from liberasurecode
1.5.0 and earlier in a system with multiple readers and writers:
* Before upgrade, ensure the environment variable is set on all nodes.
This will be ignored by earlier versions.
* Upgrade liberasurecode on each node in the system, restarting any
services that use it. Every node continues writing CRCs that are
still usable by nodes that have not yet upgraded.
* Now that every node is capable of reading zlib CRCs, remove the
environment variable from each node to start writing new CRCs.
If you are already using 1.6.0 or later, just upgrade normally.
Closes-Bug: #1886088
Closes-Bug: #1867937
Related-Bug: #1666320
Needed-By: https://review.opendev.org/#/c/739164/
Change-Id: I9adfbe631a2dddc592fd08f8a325f3e8331b92f1
Diffstat (limited to 'test')
| -rw-r--r-- | test/liberasurecode_test.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/test/liberasurecode_test.c b/test/liberasurecode_test.c index e60140f..714ee8a 100644 --- a/test/liberasurecode_test.c +++ b/test/liberasurecode_test.c @@ -475,7 +475,11 @@ static void validate_fragment_checksum(struct ec_args *args, assert(false); //currently only have support crc32 break; case CHKSUM_CRC32: - computed = crc32(0, (unsigned char *) fragment_data, size); + if (getenv("LIBERASURECODE_WRITE_LEGACY_CRC")) { + computed = liberasurecode_crc32_alt(0, fragment_data, size); + } else { + computed = crc32(0, (unsigned char *) fragment_data, size); + } break; case CHKSUM_NONE: assert(metadata->chksum_mismatch == 0); @@ -1341,6 +1345,13 @@ static void test_get_fragment_metadata(const ec_backend_id_t be_id, struct ec_ar free(orig_data); } +static void test_write_legacy_fragment_metadata(const ec_backend_id_t be_id, struct ec_args *args) +{ + setenv("LIBERASURECODE_WRITE_LEGACY_CRC", "1", 1); + test_get_fragment_metadata(be_id, args); + unsetenv("LIBERASURECODE_WRITE_LEGACY_CRC"); +} + static void test_decode_with_missing_data(const ec_backend_id_t be_id, struct ec_args *args) { @@ -1855,6 +1866,7 @@ static void test_metadata_crcs_be() TEST(test_fragments_needed, backend, CHKSUM_NONE), \ TEST(test_get_fragment_metadata, backend, CHKSUM_NONE), \ TEST(test_get_fragment_metadata, backend, CHKSUM_CRC32), \ + TEST(test_write_legacy_fragment_metadata, backend, CHKSUM_CRC32), \ TEST(test_verify_stripe_metadata, backend, CHKSUM_CRC32), \ TEST(test_verify_stripe_metadata_libec_mismatch, backend, CHKSUM_CRC32), \ TEST(test_verify_stripe_metadata_magic_mismatch, backend, CHKSUM_CRC32), \ |