diff options
| author | Tim Burke <tim.burke@gmail.com> | 2017-01-25 23:40:32 +0000 |
|---|---|---|
| committer | Tim Burke <tim.burke@gmail.com> | 2017-03-16 17:49:49 +0000 |
| commit | 842b4a9bd71f0ee6390bf3ace71666a9acc017fd (patch) | |
| tree | 32af62e274402736f7c6ba4182ebc86407fd2c7a /test | |
| parent | 4ab1336cabe0c1f5d7fc18c21b78f5d21aca5b60 (diff) | |
| download | liberasurecode-842b4a9bd71f0ee6390bf3ace71666a9acc017fd.tar.gz | |
Jerasure: Handle initialization errors correctly
Otherwise we can get backtraces where we try to free something that was
never initialized.
Change-Id: Iaea427b977fd20819e2da5678cc4889d3a42dd65
Diffstat (limited to 'test')
| -rw-r--r-- | test/liberasurecode_test.c | 32 |
1 files changed, 27 insertions, 5 deletions
diff --git a/test/liberasurecode_test.c b/test/liberasurecode_test.c index a80e324..04a0d50 100644 --- a/test/liberasurecode_test.c +++ b/test/liberasurecode_test.c @@ -1416,8 +1416,7 @@ static void test_decode_with_missing_multi_data_parity( } } -static void test_decode_reconstruct_specific_error_case( - const ec_backend_id_t be_id, struct ec_args *args) +static void test_isa_l_rs_vand_decode_reconstruct_specific_error_case() { struct ec_args specific_1010_args = { .k = 10, @@ -1511,6 +1510,25 @@ static void test_decode_reconstruct_specific_error_case( free(skips); } +static void test_jerasure_rs_cauchy_init_failure() +{ + struct ec_args bad_args = { + .k = 10, + .m = 10, + .w = 4, + }; + // NB: (k + m) > (1 << w) => too many frags! + + int desc = -1; + desc = liberasurecode_instance_create( + EC_BACKEND_JERASURE_RS_CAUCHY, &bad_args); + if (-EBACKENDNOTAVAIL == desc) { + fprintf (stderr, "Backend library not available!\n"); + return; + } + assert(-EBACKENDINITERR == desc); +} + static void test_simple_encode_decode(const ec_backend_id_t be_id, struct ec_args *args) { @@ -1991,6 +2009,10 @@ struct testcase testcases[] = { test_verify_stripe_metadata_frag_idx_invalid, EC_BACKEND_JERASURE_RS_CAUCHY, CHKSUM_CRC32, .skip = false}, + {"test_jerasure_rs_cauchy_init_failure", + test_jerasure_rs_cauchy_init_failure, + EC_BACKENDS_MAX, 0, + .skip = false}, // ISA-L rs_vand tests {"create_and_destroy_backend", test_create_and_destroy_backend, @@ -2052,10 +2074,10 @@ struct testcase testcases[] = { test_verify_stripe_metadata_frag_idx_invalid, EC_BACKEND_ISA_L_RS_VAND, CHKSUM_CRC32, .skip = false}, - {"test_isa_l_decode_reconstruct_specific_error_case", - test_decode_reconstruct_specific_error_case, + {"test_isa_l_rs_vand_decode_reconstruct_specific_error_case", + test_isa_l_rs_vand_decode_reconstruct_specific_error_case, EC_BACKENDS_MAX, 0, // note this test is using ISA-L in hard coded - .skip = false}, + .skip = false}, // ISA-L rs cauchy tests {"create_and_destroy_backend", test_create_and_destroy_backend, |