| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I9102f9883e979862557bd33958b2d116795b3169
Closes-Bug: #1726816
|
|
|
|
|
|
| |
Previously, we'd segfault with args like k=1, m=3, hd=3.
Change-Id: I8a1d92f388c54fe4f5b357eaf85a27e6b334df11
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Can you believe that we ware testing the memory leak with valgrind
to just *bash scripts* instead of actual binaries on liberasurecode_test
and libec_slap?
That is why we cannot find such an easy memory leak[1] at the gate.
Now this patch enable to run the valgrind against to the binaries.
With this fix, we found various memory leak at liberasurecode_test as
follows and this patch also fixes them:
- If we create fake fragments, we're responsible for freeing all of the
frags as well as the array holding the pointers to the frags.
- If we allocate any space, we're responsible for freeing it.
- If we create an EC descriptor, we're responsible for destroying it.
- If we create a fragment or skip array, we're responsible for freeing it.
- If that happens inside a loop, we're responsible for doing it *inside
that same loop*.
In addition to the test fix, this patch fixes following memory leaks at
the code which is affected to other users (pyeclib, OpenStack Swift)
* Refuse to decode fragments that aren't even long enough to include
fragment headers.
* Fix a small memory leak in the builtin rs_vand implementation.
Closes-Bug: #1665242
Co-Authored-By: Tim Burke <tim@swiftstack.com>
1: https://review.openstack.org/#/c/431812
Change-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2
|
| |
|
| |
|
| |
|
|
|
|
| |
This is meant to be used in cases where ISA-L and Jerasure cannot be used.
|
|
|
|
|
|
| |
Also added additional test to test_xor_code to do an exhaustive decode test
(all possible 1 and 2 disk failures) and changed teh default liberasurecode
test to test (3, 3, 3).
|
|
|
|
|
|
| |
header in the xor-encoder.
FWIW, we did conditional compilation in the body of the code, but missed the header include.
|
| |
|
|
|
|
| |
little clean-up, but the tests are passing...
|
|
|
|
| |
existing warnings.
|
| |
|
|
|
|
|
| |
Currently only works on Linux (build/tests will run on OS X but
coverage data is not generated).
|
|
|
|
| |
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
|
|
|
|
|
| |
.. also introduce a map for backend method stub name
to backend library function names
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
|
|
|
|
|
| |
Facing some nasty dlopen() issues when testing with
"test/liberasurecode_test"
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
|
|
| |
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
|
|
| |
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
|
|
| |
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
|
|
| |
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|
|
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>
|