diff options
| author | Nick Mathewson <nickm@torproject.org> | 2010-01-22 16:14:49 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2010-01-22 16:14:49 -0500 |
| commit | ff3f6cd42b8d58d6db9c2ceb2cf9868d1a8f7ec0 (patch) | |
| tree | 4fb607e14f39043f1f8a0d05c99a3d4e37bae1a3 /bufferevent_pair.c | |
| parent | 7296971b105ffc2bc9d20b0a24a3055c2ecf5e69 (diff) | |
| download | libevent-ff3f6cd42b8d58d6db9c2ceb2cf9868d1a8f7ec0.tar.gz | |
Check more internal event_add() calls for failure
Most of these should be unable to fail, since adding a timeout
generally always works. Still, it's better not to try to be "too
smart for our own good here."
There are some remaining event_add() calls that I didn't add checks
for; I've marked those with "XXXX" comments.
Diffstat (limited to 'bufferevent_pair.c')
| -rw-r--r-- | bufferevent_pair.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/bufferevent_pair.c b/bufferevent_pair.c index 34880462..fc00a7c2 100644 --- a/bufferevent_pair.c +++ b/bufferevent_pair.c @@ -226,7 +226,8 @@ be_pair_enable(struct bufferevent *bufev, short events) incref_and_lock(bufev); - _bufferevent_generic_adj_timeouts(bufev); + if (_bufferevent_generic_adj_timeouts(bufev) < 0) + return -1; /* We're starting to read! Does the other side have anything to write?*/ if ((events & EV_READ) && partner && @@ -245,8 +246,7 @@ be_pair_enable(struct bufferevent *bufev, short events) static int be_pair_disable(struct bufferevent *bev, short events) { - _bufferevent_generic_adj_timeouts(bev); - return 0; + return _bufferevent_generic_adj_timeouts(bev); } static void |