diff options
| author | Azat Khuzhin <a3at.mail@gmail.com> | 2017-08-14 23:11:53 +0300 |
|---|---|---|
| committer | Azat Khuzhin <a3at.mail@gmail.com> | 2017-08-14 23:16:12 +0300 |
| commit | a10a6f4ed918ea1432820d99e9373f37f906d6f0 (patch) | |
| tree | 7ba671a7b5207393b3799e457d2924503adc4012 /bufferevent_sock.c | |
| parent | b26996a05d9e7aad32e78a7bfab6454d5c11500a (diff) | |
| download | libevent-a10a6f4ed918ea1432820d99e9373f37f906d6f0.tar.gz | |
Remove check against passed bufferevent in bufferevent_socket_connect()
It is a bit confusing to check against the result of EVUTIL_UPCAST(),
because it can return not NULL for NULL pointers, but for even though
with bufferevent we are fine (because bufferevent is the first field in
bufferevent_private), there are no checks for "bufev" in bufferevent's
API, so just remove it to make it generic.
Fixes: #542
Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com>
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
Diffstat (limited to 'bufferevent_sock.c')
| -rw-r--r-- | bufferevent_sock.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/bufferevent_sock.c b/bufferevent_sock.c index e305ec55..38f791ee 100644 --- a/bufferevent_sock.c +++ b/bufferevent_sock.c @@ -389,9 +389,6 @@ bufferevent_socket_connect(struct bufferevent *bev, bufferevent_incref_and_lock_(bev); - if (!bufev_p) - goto done; - fd = bufferevent_getfd(bev); if (fd < 0) { if (!sa) |