summaryrefslogtreecommitdiff
path: root/evrpc.c
diff options
context:
space:
mode:
authorAzat Khuzhin <azat@libevent.org>2019-04-01 02:37:41 +0300
committerAzat Khuzhin <azat@libevent.org>2019-04-01 02:42:07 +0300
commit7a8cc11406db7f3ea70425b71e31ece0b07e9e08 (patch)
treec8173e4fb58dc3c60fd9a79f883eabc536805936 /evrpc.c
parente5b8f4c1925867d8e4cd7dc0390e5141d7ef1106 (diff)
downloadlibevent-7a8cc11406db7f3ea70425b71e31ece0b07e9e08.tar.gz
evrpc: do not check req twice
reported by µchex: "In evrpc.c, pointer req is dereferenced on line 881 before it is null checked on line 894."
Diffstat (limited to 'evrpc.c')
-rw-r--r--evrpc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/evrpc.c b/evrpc.c
index 3b5260fc..46bf3f7e 100644
--- a/evrpc.c
+++ b/evrpc.c
@@ -892,8 +892,7 @@ evrpc_reply_done(struct evhttp_request *req, void *arg)
* layer is going to free it. we need to
* request ownership explicitly
*/
- if (req != NULL)
- evhttp_request_own(req);
+ evhttp_request_own(req);
evrpc_pause_request(pool, ctx,
evrpc_reply_done_closure);