summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorfanquake <fanquake@gmail.com>2021-03-28 10:57:11 +0800
committerfanquake <fanquake@gmail.com>2021-03-28 10:57:11 +0800
commit4c29b01c87af4739a0e846f5879fa0f5db287f10 (patch)
treed9660aaae64235efcd301519fc08cc7b91fd8a1e /include
parent8e5e7bb8a82458ba5ac4193d88cef38a3ad6dddb (diff)
downloadlibevent-4c29b01c87af4739a0e846f5879fa0f5db287f10.tar.gz
build: remove splice implementation fragments
Looks like a `splice` implementation was planned, but has clearly never eventuated (the TODO comment is from ~12 years ago, in 8b5bd77415fb6634fadf08357676926fecf5f032). For now, it's probably better to remove the unused code/correct the docs.
Diffstat (limited to 'include')
-rw-r--r--include/event2/buffer.h11
1 files changed, 5 insertions, 6 deletions
diff --git a/include/event2/buffer.h b/include/event2/buffer.h
index a9afc3c6..5a76cf20 100644
--- a/include/event2/buffer.h
+++ b/include/event2/buffer.h
@@ -552,10 +552,9 @@ int evbuffer_add_file(struct evbuffer *outbuf, int fd, ev_off_t offset,
/**
An evbuffer_file_segment holds a reference to a range of a file --
possibly the whole file! -- for use in writing from an evbuffer to a
- socket. It could be implemented with mmap, sendfile, splice, or (if all
- else fails) by just pulling all the data into RAM. A single
- evbuffer_file_segment can be added more than once, and to more than one
- evbuffer.
+ socket. It could be implemented with mmap or sendfile, or (if all else
+ fails) by just pulling all the data into RAM. A single evbuffer_file_segment
+ can be added more than once, and to more than one evbuffer.
*/
struct evbuffer_file_segment;
@@ -572,7 +571,7 @@ struct evbuffer_file_segment;
#define EVBUF_FS_DISABLE_MMAP 0x02
/**
Flag for creating evbuffer_file_segment: Disable direct fd-to-fd
- implementations (including sendfile and splice).
+ implementations (sendfile).
You might want to use this option if data needs to be taken from the
evbuffer by any means other than writing it to the network: the sendfile
@@ -600,7 +599,7 @@ typedef void (*evbuffer_file_segment_cleanup_cb)(
file and sending it out via an evbuffer.
This function avoids unnecessary data copies between userland and
- kernel. Where available, it uses sendfile or splice.
+ kernel. Where available, it uses sendfile.
The file descriptor must not be closed so long as any evbuffer is using
this segment.