summaryrefslogtreecommitdiff
path: root/http.c
Commit message (Collapse)AuthorAgeFilesLines
* http: style fix: use space between arguments list (#1435)Liao Tonglang2023-03-261-1/+1
|
* http: Reduce times of checking if response has body (#1395)Liao Tonglang2023-03-051-3/+4
| | | | Use a variable 'need_body' to store the result of evhttp_response_needs_body(), then use the variable instead of call the function again.
* Fix the value is never actually read from 'argument' in ↵Cœur2023-03-021-4/+2
| | | | | | | evhttp_parse_query_impl() Although the value stored to 'argument' is used in the enclosing expression, the value is never actually read from 'argument'
* ws: fix compile error on centos 7 - very old compiler (#1359)Leon George2022-10-231-1/+1
| | | | | | | | | | | | | | * http: fix typo * ws: fix comile error On CentOS: CC ws.lo ws.c: In function 'get_ws_frame': ws.c:244:3: error: 'for' loop initial declarations are only allowed in C99 mode for (int i = 0; i < payload_len; i++) { ^ ws.c:244:3: note: use option -std=c99 or -std=gnu99 to compile your code
* Add minimal WebSocket server implementation for evhttp (#1322)Dmitry Ilyin2022-09-121-0/+32
| | | | | | | | | | | | | | This adds few functions to use evhttp-based webserver to handle incoming WebSockets connections. We've tried to use both libevent and libwebsockets in our application, but found that we need to have different ports at the same time to handle standard HTTP and WebSockets traffic. This change can help to stick only with libevent library. Implementation was inspired by modified Libevent source code in ipush project [1]. [1]: https://github.com/sqfasd/ipush/tree/master/deps/libevent-2.0.21-stable Also, WebSocket-based chat server was added as a sample.
* Fix non-std printf %p arguments (#1327)mareksm2022-08-281-4/+4
| | | | | * Fix non-std printf %p arguments when running with -Werror -pedantic-errors Co-authored-by: Mareks Malnacs <mareks.malnacs>
* http: allow setting bevcb per socketLeon M. George2022-08-131-10/+27
| | | | | Co-authored-by: Azat Khuzhin <azat@libevent.org> v2: remove handling of HTTP_BIND_IPV6
* http: suppress "flags may be used uninitialized in this function" errorAzat Khuzhin2022-07-091-2/+4
| | | | | | | | | | | | | | Some GCC reports [1]: /home/runner/work/libevent/libevent/http.c: In function ‘evhttp_make_header’: /home/runner/work/libevent/libevent/http.c:503:14: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ev_uint16_t flags; ^~~~~ /home/runner/work/libevent/libevent/http.c: In function ‘evhttp_get_body’: /home/runner/work/libevent/libevent/http.c:2354:14: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ev_uint16_t flags; ^~~~~ [1]: https://github.com/libevent/libevent/runs/7263518338?check_suite_focus=true#logs
* http: fix building under windows (guard with _WIN32 for unixsocket free)Azat Khuzhin2021-08-121-0/+2
| | | | Reported-by: @kaend
* http: support unix domain socketsSean Young2021-08-101-34/+160
| | | | | | | | | | | There are no standard for encoding a unix socket in an url. nginx uses: http://unix:/path/to/unix/socket:/httppath The second colon is needed to delimit where the unix path ends and where the rest of the url continues. Signed-off-by: Sean Young <sean@mess.org>
* http: fix fd leak on fd reset (by using bufferevent_replacefd())Azat Khuzhin2021-03-231-4/+4
| | | | Fixes: afa66ea4 ("http: eliminate redundant bev fd manipulating and caching [WIP]")
* http: fix invalid unsigned arithmeticihsinme2021-02-111-1/+1
|
* http: eliminate redundant bev fd manipulating and caching [WIP]Azat Khuzhin2020-10-311-88/+58
| | | | | | | | | | | | | | | | | At the very beginning we reset the bufferevent fd (if bev has it), which is not a good idea, since if user passes bufferevent with existing fd he has some intention. So we need to: - use BEV_OPT_CLOSE_ON_FREE for default bufferevent_socket_new() (to avoid manual shutdown/closee) - drop getsockopt(SOL_SOCKET, SO_ERROR), since bufferevent already has evutil_socket_finished_connecting_() - drop supperior bufferevent_setfd(bev, -1) in evhttp_connection_connect_() Closes: #795 Refs: #875
* http: add EVHTTP_URI_HOST_STRIP_BRACKETSAzat Khuzhin2020-10-271-15/+54
| | | | Refs: #1115
* http: const out address param to evcon_get_peerLeon M. George2020-09-091-1/+1
|
* Check error code of evhttp_add_header_internal() in evhttp_parse_query_impl()Azat Khuzhin2020-06-251-1/+4
|
* http: Merge branch 'http-max_connections-pr-592'Azat Khuzhin2020-05-251-1/+39
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | @jcoffland: "When the max connection limit is enabled and the limit is reached, the server will respond immediately with 503 Service Unavailable. This can be used to prevent servers from running out of file descriptors. This is better than request limiting because clients may make more than one request over a single connection. Blocking a request does not necessarily close the connection and free up a socket." * http-max_connections-pr-592: test: cover evhttp max connections Added evhttp max simultaneous connection limiting
| * Added evhttp max simultaneous connection limitingJoseph Coffland2018-01-301-1/+39
| |
* | http: fix EVHTTP_CON_AUTOFREE in case of timeout (and some else)Azat Khuzhin2020-05-191-0/+5
| | | | | | | | Refs: #182
* | http: fix EVHTTP_CON_AUTOFREE in case of connection errorAzat Khuzhin2020-05-191-0/+8
| | | | | | | | Refs: #182
* | Add callback support for error pagesnntrab2020-01-131-45/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing error pages are very basic and don't allow for multi-lingual support or for conformity with other pages in a web site. The aim of the callback functionality is to allow custom error pages to be supported for calls to evhttp_send_error() by both calling applications and Libevent itself. A backward-incompatible change has been made to the title of error pages sent by evhttp_send_error(). The original version of the function used the reason argument as part of the title. That might have unforeseen side-effects if it contains HTML tags. Therefore the title has been changed to always use the standard status text. An example of the error callback can be found in this [version](https://github.com/libevent/libevent/files/123607/http-server.zip) of the 'http-server' sample. It will output error pages with very bright backgrounds, the error code using a very large font size and the reason. Closes: #323 (cherr-picked from PR)
* | http: do not close connection for CONNECTAzat Khuzhin2020-01-121-0/+3
| |
* | http: do not assume body for CONNECTAzat Khuzhin2020-01-121-0/+1
| |
* | http: rename bind_socket_ai() to create_bind_socket_nonblock()yuangongji2019-09-181-5/+4
| |
* | http: make sure the other fields in ext_method are not changed by the callbackyuangongji2019-09-181-1/+12
| |
* | http: do not name variable "sun" since this breaks solaris buildsAzat Khuzhin2019-05-251-2/+2
| | | | | | | | | | -bash-3.2$ /opt/csw/bin/gcc -xc /dev/null -dM -E | grep '#define sun' #define sun 1
* | http: avoid use of uninitialized value for AF_UNIX/AF_LOCAL sockaddrAzat Khuzhin2019-05-121-2/+16
| | | | | | | | unixsock peer does not have sun_path initialized.
* | Added http method extendingThomas Bernard2019-04-111-38/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | User can define his own response method by calling evhttp_set_ext_method_cmp() on the struct http, or evhttp_connection_set_ext_method_cmp() on the connection. We expose a new stucture `evhttp_ext_method` which is passed to the callback if it's set. So any field can be modified, with some exceptions (in evhttp_method_): If the cmp function is set, it has the ability to modify method, and flags. Other fields will be ignored. Flags returned are OR'd with the current flags. Based on changes to the #282 from: Mark Ellzey <socket@gmail.com>
* | http: Update allowed_methods field from 16 to 32bits.Thomas Bernard2019-04-111-1/+1
| |
* | http: replace EVHTTP_REQ_UNKNOWN_ with 0Azat Khuzhin2019-04-101-8/+7
| | | | | | | | | | | | | | | | | | | | | | From the server perspective the evhttp_response_phrase_internal() should not be called with 0 before this patch, it will be called with EVHTTP_REQ_UNKNOWN_ hence this patch should not change behavior. Fixes: 68eb526d7b ("http: add WebDAV methods support") Fixes: #789 Fixes: #796 Reported-by: Thomas Bernard <miniupnp@free.fr>
* | http: add WebDAV methods supportAlexander Drozdov2019-03-141-12/+96
| | | | | | | | | | | | | | WebDAV introduced new HTTP methods (RFC4918): PROPFIND, PROPPATCH, MKCOL, LOCK, UNLOCK, COPY, MOVE. Add support of the methods.
* | http: suppress -Wwrite-string in evhttp_parse_query_impl()Azat Khuzhin2019-03-131-1/+1
| |
* | http: implement separate timeouts for read/write/connect phaseAzat Khuzhin2019-03-051-50/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch allows to change timeout for next events read/write/connect separatelly, using new API: - client: evhttp_connection_set_connect_timeout_tv() -- for connect evhttp_connection_set_read_timeout_tv() -- for read evhttp_connection_set_write_timeout_tv() -- for write - server: evhttp_set_read_timeout_tv() -- for read evhttp_set_write_timeout_tv() -- for write It also changes a logic a little, before there was next fallbacks which does not handled in new API: - HTTP_CONNECT_TIMEOUT - HTTP_WRITE_TIMEOUT - HTTP_READ_TIMEOUT And introduce another internal flag (EVHTTP_CON_TIMEOUT_ADJUSTED) that will be used in evrpc, which adjust evhttp_connection timeout only if it is not default. Fixes: #692 Fixes: #715
* | http: try to read existing data in buffer under EVHTTP_CON_READ_ON_WRITE_ERRORAzat Khuzhin2019-01-291-0/+8
| | | | | | | | | | | | | | | | | | | | | | There are two possible ways of getting response from the server: - processing existing bufferevent buffer - reading from the socket (even after write() errored with -1, it is still possible) But we did not tried the first option, only the second one. Fixes: http/read_on_write_error (on freebsd/osx)
* | http: do not call deferred readcb if readcb is not setAzat Khuzhin2019-01-281-1/+3
| | | | | | | | | | | | | | Otherwise evhttp_read_cb can be called with invalid connection state: http/read_on_write_error: [forking] [msg] libevent using: kqueue FAIL ../test/regress_http.c:4079: assert(req) FAIL ../test/regress_http.c:4087: assert(req)[err] evhttp_read_cb: illegal connection state 0
* | http: Preserve socket error from listen across closesocket cleanupLuke Dashjr2019-01-071-0/+3
| | | | | | | | Closes: #738 (cherry-picked)
* | http: fix connection retries when there more then one request for connectionAzat Khuzhin2018-12-121-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should not attemp to establishe the connection if there is retry timer active, since otherwise there will be a bug. Imagine next situation: con = evhttp_connection_base_new() evhttp_connection_set_retries(con, 2) req = evhttp_request_new() evhttp_make_request(con, req, ...) # failed during connecting, and timer for 2 second scheduler (retry_ev) Then another request scheduled for this evcon: evhttp_make_request(con, req, ...) # got request from server, # and now it tries to read the response from the server # (req.kind == EVHTTP_RESPONSE) # # but at this point retry_ev scheduled, # and it schedules the connect again, # and after the connect will succeeed, it will pick request with # EVHTTP_RESPONSE for sending and this is completelly wrong and will # fail in evhttp_make_header_response() since there is no # "http_server" for this evcon This was a long standing issue, that I came across few years ago firstly, bad only now I had time to dig into it (but right now it was pretty simple, by limiting amount of CPU for the process and using rr for debug to go back and forth).
* | http: improve error path for bufferevent_{setfd,enable,disable}()Azat Khuzhin2018-11-201-9/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We have calls to the next functions but do not check return values, though they can be invalid and it is better to show this somehow. Also do bufferevent_setfd() first and only after it bufferevent_enable()/bufferevent_disable() since: a) it is more natural b) it will avoid extra operations c) it will not fail first bufferevent_enable() (this is the case for buffbufferevent_async at least) In this case we could add more information for issues like #709
* | Fix conceivable UAF of the bufferevent in evhttp_connection_free()Azat Khuzhin2018-11-131-8/+10
| | | | | | | | | | | | | | | | | | Although this is not a problem, since bufferevent uses finalizers and will free itself only from the loop (well this is not a problem if you do not play games with various event_base in different threads) it generates questions, so rewrite it in more reliable way. Fixes: #712
* | Add evhttp_parse_query_str_flags()Azat Khuzhin2018-10-271-5/+18
| | | | | | | | | | | | | | | | And a set of flags: - EVHTTP_URI_QUERY_LAST - EVHTTP_URI_QUERY_NONCONFORMANT Fixes: #15
* | http: allow non RFC3986 conformant during parsing request-line (http server)Azat Khuzhin2018-10-231-8/+8
| | | | | | | | Reported-by: lsdyst@163.com
* | http: do not try to parse request-line if we do not have enough bytesAzat Khuzhin2018-10-221-0/+2
| |
* | http: allow trailing spaces (and only them) in request-line (like nginx)Azat Khuzhin2018-10-221-2/+9
| |
* | http: cleanup of the request-line parsingAzat Khuzhin2018-10-221-11/+10
| |
* | [http] fix C90 warningsNathan French2018-07-051-1/+3
| |
* | Fix evhttp_connection_get_addr() fox incomming http connectionsGreg Hazel2018-04-241-0/+1
| | | | | | | | | | | | | | | | | | Install conn_address of the bufferevent on incomping http connections (even though this is kind of subsytem violation, so let's fix it in a simplest way and thinkg about long-term solution). Fixes: #510 Closes: #595 (pick)
* | http: remove message in case !Content-Length and Connection!=closeAzat Khuzhin2018-02-201-4/+0
|/ | | | | | | | | | | Since [1] GET can have body, and hence for every incomming connection it will print this error. [1] db483e3b002b33890fc88cadd77f6fd1fccad2d2 ("Allow bodies for GET/DELETE/OPTIONS/CONNECT") Noticed-by: BotoX (irc) Refs: #408
* http: fix leaks in evhttp_uriencode()Azat Khuzhin2018-01-091-10/+10
| | | | Fixes: #584
* http: add callback to allow server to decline (and thereby close) incoming ↵John Fremlin2017-12-181-7/+18
| | | | | | | | | | | connections. This is important, as otherwise clients can easily exhaust the file descriptors available on a libevent HTTP server, which can cause problems in other code which does not handle EMFILE well: for example, see https://github.com/bitcoin/bitcoin/issues/11368 Closes: #578 (patch cherry picked)
* CONNECT method only takes an authorityGreg Hazel2017-12-111-3/+38
|
View Lorry Controller Status