diff options
| author | NIIBE Yutaka <gniibe@fsij.org> | 2019-10-24 11:47:53 +0900 |
|---|---|---|
| committer | NIIBE Yutaka <gniibe@fsij.org> | 2019-10-24 11:47:53 +0900 |
| commit | 3d5a05767b84e0f781ed5dfe434adb4d4e9d2aa5 (patch) | |
| tree | 2e3454ff95bbf5c0609fa8a821237d9e68093e8b | |
| parent | 8fce1027c2531127dd52a8b883f34333ffd3763b (diff) | |
| download | libgcrypt-3d5a05767b84e0f781ed5dfe434adb4d4e9d2aa5.tar.gz | |
ecc: Fix handling of point representation in EdDSA.
* cipher/ecc-eddsa.c (_gcry_ecc_eddsa_ensure_compact): Use
GCRYMPI_FMT_USG, since integer is defined as unsigned in SEC1.
(_gcry_ecc_eddsa_decodepoint): Likewise.
--
It has been not an issue because it's 2^255 - 19 only (MSB is always
cleared).
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
| -rw-r--r-- | cipher/ecc-eddsa.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/cipher/ecc-eddsa.c b/cipher/ecc-eddsa.c index f1621584..d4bedb0a 100644 --- a/cipher/ecc-eddsa.c +++ b/cipher/ecc-eddsa.c @@ -168,11 +168,11 @@ _gcry_ecc_eddsa_ensure_compact (gcry_mpi_t value, unsigned int nbits) { /* Buffer is in SEC1 uncompressed format. Extract y and compress. */ - rc = _gcry_mpi_scan (&x, GCRYMPI_FMT_STD, + rc = _gcry_mpi_scan (&x, GCRYMPI_FMT_USG, buf+1, (rawmpilen-1)/2, NULL); if (rc) return rc; - rc = _gcry_mpi_scan (&y, GCRYMPI_FMT_STD, + rc = _gcry_mpi_scan (&y, GCRYMPI_FMT_USG, buf+1+(rawmpilen-1)/2, (rawmpilen-1)/2, NULL); if (rc) { @@ -316,11 +316,11 @@ _gcry_ecc_eddsa_decodepoint (gcry_mpi_t pk, mpi_ec_t ctx, mpi_point_t result, { gcry_mpi_t x, y; - rc = _gcry_mpi_scan (&x, GCRYMPI_FMT_STD, + rc = _gcry_mpi_scan (&x, GCRYMPI_FMT_USG, buf+1, (rawmpilen-1)/2, NULL); if (rc) return rc; - rc = _gcry_mpi_scan (&y, GCRYMPI_FMT_STD, + rc = _gcry_mpi_scan (&y, GCRYMPI_FMT_USG, buf+1+(rawmpilen-1)/2, (rawmpilen-1)/2,NULL); if (rc) { |