localalloc: Abort on EBADF from close() by default

systemd does this by default. I think we should treat this as a fatal error
since it can cause really painful-to-debug problems if we don't just get
EBADF but actually close something else's fd due to a race.

1 files changed, 2 insertions, 1 deletions

diff --git a/glnx-local-alloc.h b/glnx-local-alloc.h
index 8c1914c..af8d72f 100644
--- a/glnx-local-alloc.h
+++ b/glnx-local-alloc.h
@@ -204,7 +204,8 @@ glnx_cleanup_close_fdp (int *fdp)
   if (fd >= 0)
     {
       errsv = errno;
-      (void) close (fd);
+      if (close (fd) < 0)
+        g_assert (errno != EBADF);
       errno = errsv;
     }
 }