diff options
| author | Liping Zhang <zlpnobody@gmail.com> | 2017-03-19 22:01:10 +0800 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-03-21 11:41:21 +0100 |
| commit | 9f223e612d3b0be6e4dca84e1db8042dbec64e93 (patch) | |
| tree | f8ea2432aa76768c901b8377173ab6575c5c8ff5 | |
| parent | f58c5b09fb59baf07c942d373fc4d522b27e73c6 (diff) | |
| download | libnetfilter_cthelper-9f223e612d3b0be6e4dca84e1db8042dbec64e93.tar.gz | |
examples: fix double free in nftc-helper-add
After inputting the following test command, core dump happened:
# ./examples/nfct-helper-add test 1
*** Error in
`.../libnetfilter_cthelper/examples/.libs/lt-nfct-helper-add':
double free or corruption (fasttop): 0x0000000001f3c070 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x77de5)[0x7fd9ebe88de5]
/lib64/libc.so.6(+0x8022a)[0x7fd9ebe9122a]
/lib64/libc.so.6(cfree+0x4c)[0x7fd9ebe9478c]
[...]
Because "struct nfct_helper_policy *p" had been freed by nfct_helper_free,
so there's no need to invoke nfct_helper_policy_free again, otherwise
double free error will happen.
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | examples/nfct-helper-add.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/examples/nfct-helper-add.c b/examples/nfct-helper-add.c index 6c47626..cb7291e 100644 --- a/examples/nfct-helper-add.c +++ b/examples/nfct-helper-add.c @@ -32,6 +32,7 @@ int main(int argc, char *argv[]) nfct_helper_attr_set_u16(nfct_helper, NFCTH_ATTR_PROTO_L3NUM, AF_INET); nfct_helper_attr_set_u8(nfct_helper, NFCTH_ATTR_PROTO_L4NUM, IPPROTO_TCP); + /* Will be freed by nfct_helper_free. */ p = nfct_helper_policy_alloc(); if (p == NULL) { perror("OOM"); @@ -49,7 +50,6 @@ int main(int argc, char *argv[]) nfct_helper_nlmsg_build_payload(nlh, nfct_helper); nfct_helper_free(nfct_helper); - nfct_helper_policy_free(p); nl = mnl_socket_open(NETLINK_NETFILTER); if (nl == NULL) { |