summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2021-10-05 11:20:45 +0100
committerFabiano FidĂȘncio <fabiano@fidencio.org>2021-10-10 12:20:08 +0000
commit0cf18c28bbb18fef643550b38b57fd8a31924d42 (patch)
tree5b794435c47d5e0553fbbc4bf4ee99bb8cfb256c
parente305a15bf93a0b95f370b764001a3a34ff0f3af2 (diff)
downloadlibosinfo-0cf18c28bbb18fef643550b38b57fd8a31924d42.tar.gz
Skip over entity reference checks if loading failed
If we fail to parse one of the XML files, we abort loading the database. We then carry on to do an entity reference check which will almost certainly fail due to not having loaded many XML files. We need to skip over the entity reference check on failure to avoid spamming the user with bogus errors. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
-rw-r--r--osinfo/osinfo_loader.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index ca2c765..3f04fa5 100644
--- a/osinfo/osinfo_loader.c
+++ b/osinfo/osinfo_loader.c
@@ -2504,7 +2504,7 @@ static void osinfo_loader_process_list(OsinfoLoader *loader,
files->master, &lerr);
if (lerr) {
g_propagate_error(err, lerr);
- break;
+ goto cleanup;
}
}
@@ -2517,7 +2517,7 @@ static void osinfo_loader_process_list(OsinfoLoader *loader,
&lerr);
if (lerr) {
g_propagate_error(err, lerr);
- break;
+ goto cleanup;
}
tmpl = tmpl->next;