summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordominique.leuenberger@gmail.com <dominique.leuenberger@gmail.com@c587cffe-e639-0410-9787-d7902ae8ed56>2012-12-10 22:13:41 +0000
committerdominique.leuenberger@gmail.com <dominique.leuenberger@gmail.com@c587cffe-e639-0410-9787-d7902ae8ed56>2012-12-10 22:13:41 +0000
commit28eac062de8ba1423738692e90dc5fd818cc2873 (patch)
tree89ac1f5884522340098d4ba7629c2058a18065a8
parent7da2a5df24b54fd71d786e66da86d3003b92a73d (diff)
downloadlibproxy-28eac062de8ba1423738692e90dc5fd818cc2873.tar.gz
Fix leaks. Fixes issue 185.
git-svn-id: http://libproxy.googlecode.com/svn/trunk@870 c587cffe-e639-0410-9787-d7902ae8ed56
-rw-r--r--NEWS4
-rw-r--r--libproxy/url.cpp2
2 files changed, 6 insertions, 0 deletions
diff --git a/NEWS b/NEWS
index e9b177f..a7e13d4 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+New in version <NEXT>
+==============================
+* Fix fd leak in get_pac (Bug #185)
+
New in version 0.4.11
==============================
* Build fixes with cmake 2.8.10+
diff --git a/libproxy/url.cpp b/libproxy/url.cpp
index 772a9e9..9c69917 100644
--- a/libproxy/url.cpp
+++ b/libproxy/url.cpp
@@ -403,6 +403,7 @@ char* url::get_pac() {
buffer = NULL;
}
}
+ close(sock);
return buffer;
}
@@ -496,6 +497,7 @@ char* url::get_pac() {
// Clean up
shutdown(sock, SHUT_RDWR);
+ close(sock);
return buffer;
}