Fixes for problems found in review

- missing BR on pam-devel, license field, Source URL, Require pam, other cleanups

1 files changed, 12 insertions, 8 deletions

diff --git a/libpwquality.spec.in b/libpwquality.spec.in
index 14f79d0..54d283d 100644
--- a/libpwquality.spec.in
+++ b/libpwquality.spec.in
@@ -2,20 +2,20 @@ Summary: A library for password generation and password quality checking
 Name: libpwquality
 Version: @PACKAGE_VERSION@
 Release: 1%{?dist}
-# The library is BSD licensed with option to relicense as GPLv2+
+# The package is BSD licensed with option to relicense as GPL+
 # - this option is redundant as the BSD license allows that anyway.
-License: BSD and GPLv2+
+License: BSD or GPL+
 Group: System Environment/Base
-Source0: http://fedorahosted.org/releases/l/i/libpwquality-%{version}.tar.bz2
+Source0: http://fedorahosted.org/releases/l/i/libpwquality/libpwquality-%{version}.tar.bz2
 
-%define _moduledir /%{_lib}/security
-%define _secconfdir %{_sysconfdir}/security
+%global _moduledir /%{_lib}/security
+%global _secconfdir %{_sysconfdir}/security
 
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires: cracklib-dicts >= 2.8
-Requires(post): /sbin/ldconfig
+Requires: pam%{?_isa}
 BuildRequires: cracklib-devel
 BuildRequires: gettext
+BuildRequires: pam-devel
 
 URL: http://libpwquality.fedorahosted.org/
 
@@ -46,7 +46,7 @@ See the pwquality.h header file for the API.
 make %{?_smp_mflags}
 
 %install
-make install DESTDIR=$RPM_BUILD_ROOT
+make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
 
 mkdir -p $RPM_BUILD_ROOT%{_libdir}
 pushd $RPM_BUILD_ROOT%{_libdir}
@@ -80,5 +80,9 @@ rm -f $RPM_BUILD_ROOT%{_moduledir}/*.la
 %{_libdir}/libpwquality.so
 
 %changelog
+* Mon Oct 10 2011 Tomas Mraz <tmraz@redhat.com> 0.9-2
+- fixes for problems found in review (missing BR on pam-devel,
+  License field, Source URL, Require pam, other cleanups)
+
 * Mon Oct  3 2011 Tomas Mraz <tmraz@redhat.com> 0.9-1
 - first spec file for libpwquality