summaryrefslogtreecommitdiff
path: root/examples/simple-tester-python
diff options
context:
space:
mode:
authorAleksander Morgado <aleksander@aleksander.es>2020-09-03 14:25:58 +0200
committerAleksander Morgado <aleksander@aleksander.es>2020-09-08 08:06:45 +0000
commit5adf577f4cb1db0d1df4c2c7eea6156f1ba707a5 (patch)
tree96fcd47c997821ed6516e8cf3dc91be8d78bc46c /examples/simple-tester-python
parentcbf0a3aa21a31f7ea24ff1fb391f50670ab6ae51 (diff)
downloadlibqmi-5adf577f4cb1db0d1df4c2c7eea6156f1ba707a5.tar.gz
qmi-codegen: (skip) return value in bundle getters and setters
The return value (TRUE or FALSE) is not required in the introspection support because the method already throws an exception on failure (in other words, if there is no exception the return value would always be TRUE), so explicitly (skip) it. This commit ends up triggering an API break in the bindings generated via GObject introspection, because the getter and setter calls would now have one less return argument. E.g. instead of: success, imei = output.get_imei() We should now do: imei = output.get_imei() There is no API break in libqmi-glib.
Diffstat (limited to 'examples/simple-tester-python')
-rwxr-xr-xexamples/simple-tester-python/simple-tester-python33
1 files changed, 16 insertions, 17 deletions
diff --git a/examples/simple-tester-python/simple-tester-python b/examples/simple-tester-python/simple-tester-python
index 9319e566..af9065a9 100755
--- a/examples/simple-tester-python/simple-tester-python
+++ b/examples/simple-tester-python/simple-tester-python
@@ -64,25 +64,25 @@ def get_ids_ready(qmiclient,result,qmidev):
return
try:
- success, imei = output.get_imei()
+ imei = output.get_imei()
print("imei: %s" % imei)
except:
pass
try:
- success, imei_software_version = output.get_imei_software_version()
+ imei_software_version = output.get_imei_software_version()
print("imei software version: %s" % imei_software_version)
except:
pass
try:
- success, meid = output.get_meid()
+ meid = output.get_meid()
print("meid: %s" % meid)
except:
pass
try:
- success, esn = output.get_esn()
+ esn = output.get_esn()
print("esn: %s" % esn)
except:
pass
@@ -94,19 +94,18 @@ def get_capabilities_ready(qmiclient,result,qmidev):
try:
output = qmiclient.get_capabilities_finish(result)
output.get_result()
- success, maxtxrate, maxrxrate, dataservicecaps, simcaps, radioifaces = output.get_info()
-
- if success:
- print("max tx channel rate: %u" % maxtxrate)
- print("max rx channel rate: %u" % maxrxrate)
- print("data service: %s" % Qmi.DmsDataServiceCapability.get_string(dataservicecaps))
- print("sim: %s" % Qmi.DmsSimCapability.get_string(simcaps))
- networks = ""
- for radioiface in radioifaces:
- if networks != "":
- networks += ", "
- networks += Qmi.DmsRadioInterface.get_string(radioiface)
- print("networks: %s" % networks)
+
+ maxtxrate, maxrxrate, dataservicecaps, simcaps, radioifaces = output.get_info()
+ print("max tx channel rate: %u" % maxtxrate)
+ print("max rx channel rate: %u" % maxrxrate)
+ print("data service: %s" % Qmi.DmsDataServiceCapability.get_string(dataservicecaps))
+ print("sim: %s" % Qmi.DmsSimCapability.get_string(simcaps))
+ networks = ""
+ for radioiface in radioifaces:
+ if networks != "":
+ networks += ", "
+ networks += Qmi.DmsRadioInterface.get_string(radioiface)
+ print("networks: %s" % networks)
except GLib.GError as error:
sys.stderr.write("Couldn't query device capabilities: %s\n" % error.message)