diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2020-07-26 09:16:49 +0200 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2020-07-26 09:22:02 +0200 |
| commit | fe84793cc601c8fa8ab05de3439903eabf210317 (patch) | |
| tree | 32b021601612baa9e2c8ab8c211fffca978776d4 /src/qmi-firmware-update | |
| parent | 121e8d655ceca389d0dc7b514aa529d986ed373f (diff) | |
| download | libqmi-fe84793cc601c8fa8ab05de3439903eabf210317.tar.gz | |
qmi-firmware-update,sahara-device: avoid overflow warning
Coverity warns that there may be an unintentional overflow if the
result of (block_i * self->priv->transfer_block_size) is bigger than
max uint, which is very unlikely in our use case, but anyway, just
force an explicit cast to goffset in the operation itself to avoid the
warning.
Diffstat (limited to 'src/qmi-firmware-update')
| -rw-r--r-- | src/qmi-firmware-update/qfu-sahara-device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qmi-firmware-update/qfu-sahara-device.c b/src/qmi-firmware-update/qfu-sahara-device.c index 2aae0677..dc239b10 100644 --- a/src/qmi-firmware-update/qfu-sahara-device.c +++ b/src/qmi-firmware-update/qfu-sahara-device.c @@ -622,7 +622,7 @@ qfu_sahara_device_firehose_write_block (QfuSaharaDevice *self, g_assert (self->priv->transfer_block_size < self->priv->buffer->len); memset (self->priv->buffer->data, 0, self->priv->transfer_block_size); - offset = block_i * self->priv->transfer_block_size; + offset = block_i * (goffset)self->priv->transfer_block_size; size = qfu_image_get_size (image) - offset; if (size >= self->priv->transfer_block_size) size = self->priv->transfer_block_size; |