diff options
| author | Giuseppe Scrivano <gscrivan@redhat.com> | 2020-01-23 17:01:39 +0100 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2020-03-23 11:14:35 -0400 |
| commit | 9b129c41ac1f43d373742697aa2faf6040b9dfab (patch) | |
| tree | 25c69d113e954473adb7b5209c76b67773a383e9 /src/arch-mips64n32.h | |
| parent | f5b3166d6126f4a45b59d6af6780b5e00a0e9867 (diff) | |
| download | libseccomp-9b129c41ac1f43d373742697aa2faf6040b9dfab.tar.gz | |
arch: use gperf to generate a perfact hash to lookup syscall names
This patch significantly improves the performance of
seccomp_syscall_resolve_name since it replaces the expensive strcmp
for each syscall in the database, with a lookup table.
The complexity for syscall_resolve_num is not changed and it
uses the linear search, that is anyway less expensive than
seccomp_syscall_resolve_name as it uses an index for comparison
instead of doing a string comparison.
On my machine, calling 1000 seccomp_syscall_resolve_name_arch and
seccomp_syscall_resolve_num_arch over the entire syscalls DB passed
from ~0.45 sec to ~0.06s.
PM: After talking with Giuseppe I made a number of additional
changes, some substantial, the highlights include:
* various style tweaks
* .gitignore fixes
* fixed subject line, tweaked the description
* dropped the arch-syscall-validate changes as they were masking
other problems
* extracted the syscalls.csv and file deletions to other patches
to keep this one more focused
* fixed the x86, x32, arm, all the MIPS ABIs, s390, and s390x ABIs as
the syscall offsets were not properly incorporated into this change
* cleaned up the ABI specific headers
* cleaned up generate_syscalls_perf.sh and renamed to
arch-gperf-generate
* fixed problems with automake's file packaging
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
[PM: see notes in the "PM" section above]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'src/arch-mips64n32.h')
| -rw-r--r-- | src/arch-mips64n32.h | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/src/arch-mips64n32.h b/src/arch-mips64n32.h index fd7e542..7f9146a 100644 --- a/src/arch-mips64n32.h +++ b/src/arch-mips64n32.h @@ -23,17 +23,9 @@ #ifndef _ARCH_MIPS64N32_H #define _ARCH_MIPS64N32_H -#include <inttypes.h> - #include "arch.h" -#include "system.h" - -extern const struct arch_def arch_def_mips64n32; -extern const struct arch_def arch_def_mipsel64n32; - -int mips64n32_syscall_resolve_name(const char *name); -const char *mips64n32_syscall_resolve_num(int num); -const struct arch_syscall_def *mips64n32_syscall_iterate(unsigned int spot); +ARCH_DECL(mips64n32) +ARCH_DECL(mipsel64n32) #endif |