summaryrefslogtreecommitdiff
path: root/libtiff/tif_ojpeg.c
diff options
context:
space:
mode:
authorEven Rouault <even.rouault@spatialys.com>2014-11-20 16:47:21 +0000
committerEven Rouault <even.rouault@spatialys.com>2014-11-20 16:47:21 +0000
commitabea4b2b0480a3788993ebe625357d6594988f36 (patch)
tree6ca1a749f21411607285e422285c8753e61cd368 /libtiff/tif_ojpeg.c
parent7af4d827dd8a002e529508105a90d8f97dce91dd (diff)
downloadlibtiff-git-abea4b2b0480a3788993ebe625357d6594988f36.tar.gz
* libtiff/tif_lzw.c: prevent potential null dereference of
sp->dec_codetab in LZWPreDecode (bug #2459) * libtiff/tif_read.c: in TIFFReadBufferSetup(), avoid passing -1 size to TIFFmalloc() if passed user buffer size is 0 (bug #2459) * libtiff/tif_ojpeg.c: make Coverity happier (not a bug, #2459) * libtiff/tif_dir.c: in _TIFFVGetField() and _TIFFVSetField(), make Coverity happier (not a bug, #2459) * libtiff/tif_dirread.c: in TIFFFetchNormalTag(), make Coverity happier (not a bug, #2459) * tools/tiff2pdf.c: close PDF file (bug #2479) * tools/fax2ps.c: check malloc()/realloc() result (bug #2470) * tools/tiffdump.c: detect cycle in TIFF directory chaining (bug #2463) and avoid passing a NULL pointer to read() if seek() failed before (bug #2459) * tools/tiffcrop.c: fix segfault if bad value passed to -Z option (bug #2459) and add missing va_end in dump_info (#2459) * tools/gif2tif.c: apply patch for CVE-2013-4243 (#2451)
Diffstat (limited to 'libtiff/tif_ojpeg.c')
-rw-r--r--libtiff/tif_ojpeg.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/libtiff/tif_ojpeg.c b/libtiff/tif_ojpeg.c
index 6ea3c38b..2261ea48 100644
--- a/libtiff/tif_ojpeg.c
+++ b/libtiff/tif_ojpeg.c
@@ -1,4 +1,4 @@
-/* $Id: tif_ojpeg.c,v 1.56 2012-05-24 03:15:18 fwarmerdam Exp $ */
+/* $Id: tif_ojpeg.c,v 1.57 2014-11-20 16:47:21 erouault Exp $ */
/* WARNING: The type of JPEG encapsulation defined by the TIFF Version 6.0
specification is now totally obsolete and deprecated for new applications and
@@ -528,6 +528,8 @@ OJPEGVSetField(TIFF* tif, uint32 tag, va_list ap)
uint32 ma;
uint64* mb;
uint32 n;
+ const TIFFField* fip;
+
switch(tag)
{
case TIFFTAG_JPEGIFOFFSET:
@@ -597,7 +599,10 @@ OJPEGVSetField(TIFF* tif, uint32 tag, va_list ap)
default:
return (*sp->vsetparent)(tif,tag,ap);
}
- TIFFSetFieldBit(tif,TIFFFieldWithTag(tif,tag)->field_bit);
+ fip = TIFFFieldWithTag(tif,tag);
+ if( fip == NULL ) /* shouldn't happen */
+ return(0);
+ TIFFSetFieldBit(tif,fip->field_bit);
tif->tif_flags|=TIFF_DIRTYDIRECT;
return(1);
}