diff options
| author | Xiang, Haihao <haihao.xiang@intel.com> | 2017-10-31 05:58:24 +0800 |
|---|---|---|
| committer | Xiang, Haihao <haihao.xiang@intel.com> | 2018-01-08 14:00:41 +0800 |
| commit | fcf9041b29cee938a228dc7950955ccebb43c6bf (patch) | |
| tree | d8db0ea2dab6948438227a311ac61e89f70e224e | |
| parent | 8e687971775196fdf6986c6a2224ed70c18ac57c (diff) | |
| download | libva-intel-driver-v1.8-branch.tar.gz | |
Add upper bound check in HCP_IND_OBJ_BASE_ADDR_STATEv1.8-branch
The commit 29e375a fixed some VP9 decoding artifacts reported in
https://github.com/01org/intel-vaapi-driver/issues/262, but we still
see artifacts when decoding some VP9 clips. More investigations show
that the artifacts are caused by graphics address 0
The graphics address for a GEM BO may be 0 since the commit
below was merged into i915 KMD
commit 2889caa9232109afc8881f29a2205abeb5709d0c
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Fri Jun 16 15:05:19 2017 +0100
drm/i915: Eliminate lots of iterations over the execobjects array
So we never saw this issue before commit 2889caa
Setting upper bound to 0 causes that HW ignores upper bound check, which
works for non-zero base graphics address in HCP pipeline, however the
upper bound check is required for graphics address 0, so we add the bound
check no matter what is the graphics address
This fixes https://github.com/01org/intel-vaapi-driver/issues/297
Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
(cherry picked from commit 9d66570032fb02b1e79a883af7697b035d700a8e)
| -rw-r--r-- | src/gen9_mfd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gen9_mfd.c b/src/gen9_mfd.c index 2490b217..85a14f19 100644 --- a/src/gen9_mfd.c +++ b/src/gen9_mfd.c @@ -341,7 +341,7 @@ gen9_hcpd_ind_obj_base_addr_state(VADriverContextP ctx, OUT_BCS_BATCH(batch, HCP_IND_OBJ_BASE_ADDR_STATE | (14 - 2)); OUT_BUFFER_MA_REFERENCE(slice_data_bo); /* DW 1..3 */ - OUT_BUFFER_NMA_REFERENCE(NULL); /* DW 4..5, Upper Bound */ + OUT_BCS_RELOC64(batch, slice_data_bo, I915_GEM_DOMAIN_RENDER, 0, ALIGN(slice_data_bo->size, 4096)); OUT_BUFFER_MA_REFERENCE(NULL); /* DW 6..8, CU, ignored */ OUT_BUFFER_MA_TARGET(NULL); /* DW 9..11, PAK-BSE, ignored */ OUT_BUFFER_NMA_TARGET(NULL); /* DW 12..13, Upper Bound */ |