summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichal Privoznik <mprivozn@redhat.com>2023-04-24 10:20:52 +0200
committerMichal Privoznik <mprivozn@redhat.com>2023-04-25 12:36:31 +0200
commit4644aba0b02fb04bd8224ff932e50c41ce138f62 (patch)
tree549b3168f85b888b2aca39026196d93f28b0207a
parent430fc2ec26bfe9fafeb2a672610c40035c6e6ac1 (diff)
downloadlibvirt-4644aba0b02fb04bd8224ff932e50c41ce138f62.tar.gz
qemu: Stop virQEMUCaps propagation into qemuHostdevPreparePCIDevices()
After previous cleanups, qemuHostdevPreparePCIDevices() no longer needs virQEMUCaps. Drop its passing from callers. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
-rw-r--r--src/qemu/qemu_hostdev.c5
-rw-r--r--src/qemu/qemu_hostdev.h2
-rw-r--r--src/qemu/qemu_hotplug.c4
-rw-r--r--src/qemu/qemu_process.c3
4 files changed, 4 insertions, 10 deletions
diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
index 49347019ea..f329442f8c 100644
--- a/src/qemu/qemu_hostdev.c
+++ b/src/qemu/qemu_hostdev.c
@@ -181,7 +181,6 @@ qemuHostdevPreparePCIDevices(virQEMUDriver *driver,
const unsigned char *uuid,
virDomainHostdevDef **hostdevs,
int nhostdevs,
- virQEMUCaps *qemuCaps G_GNUC_UNUSED,
unsigned int flags)
{
return virHostdevPreparePCIDevices(driver->hostdevMgr,
@@ -261,7 +260,6 @@ qemuHostdevPrepareMediatedDevices(virQEMUDriver *driver,
int
qemuHostdevPrepareDomainDevices(virQEMUDriver *driver,
virDomainDef *def,
- virQEMUCaps *qemuCaps,
unsigned int flags)
{
if (!def->nhostdevs && !def->ndisks)
@@ -271,8 +269,7 @@ qemuHostdevPrepareDomainDevices(virQEMUDriver *driver,
return -1;
if (qemuHostdevPreparePCIDevices(driver, def->name, def->uuid,
- def->hostdevs, def->nhostdevs,
- qemuCaps, flags) < 0)
+ def->hostdevs, def->nhostdevs, flags) < 0)
return -1;
if (qemuHostdevPrepareUSBDevices(driver, def->name,
diff --git a/src/qemu/qemu_hostdev.h b/src/qemu/qemu_hostdev.h
index 2d484db878..3e9adc57a9 100644
--- a/src/qemu/qemu_hostdev.h
+++ b/src/qemu/qemu_hostdev.h
@@ -52,7 +52,6 @@ int qemuHostdevPreparePCIDevices(virQEMUDriver *driver,
const unsigned char *uuid,
virDomainHostdevDef **hostdevs,
int nhostdevs,
- virQEMUCaps *qemuCaps,
unsigned int flags);
int qemuHostdevPrepareUSBDevices(virQEMUDriver *driver,
const char *name,
@@ -73,7 +72,6 @@ int qemuHostdevPrepareMediatedDevices(virQEMUDriver *driver,
int nhostdevs);
int qemuHostdevPrepareDomainDevices(virQEMUDriver *driver,
virDomainDef *def,
- virQEMUCaps *qemuCaps,
unsigned int flags);
void qemuHostdevReAttachOneNVMeDisk(virQEMUDriver *driver,
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 7dced9ce0f..8c14540275 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1490,8 +1490,8 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver,
if (!cfg->relaxedACS)
flags |= VIR_HOSTDEV_STRICT_ACS_CHECK;
- if (qemuHostdevPreparePCIDevices(driver, vm->def->name, vm->def->uuid,
- &hostdev, 1, priv->qemuCaps, flags) < 0)
+ if (qemuHostdevPreparePCIDevices(driver, vm->def->name,
+ vm->def->uuid, &hostdev, 1, flags) < 0)
return -1;
if (qemuDomainAdjustMaxMemLockHostdev(vm, hostdev) < 0)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index c2bacfab8f..952814d663 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -7164,8 +7164,7 @@ qemuProcessPrepareHost(virQEMUDriver *driver,
hostdev_flags |= VIR_HOSTDEV_STRICT_ACS_CHECK;
if (flags & VIR_QEMU_PROCESS_START_NEW)
hostdev_flags |= VIR_HOSTDEV_COLD_BOOT;
- if (qemuHostdevPrepareDomainDevices(driver, vm->def, priv->qemuCaps,
- hostdev_flags) < 0)
+ if (qemuHostdevPrepareDomainDevices(driver, vm->def, hostdev_flags) < 0)
return -1;
VIR_DEBUG("Preparing chr device backends");