summaryrefslogtreecommitdiff
path: root/cfg.mk
diff options
context:
space:
mode:
authorJán Tomko <jtomko@redhat.com>2016-02-03 09:48:40 +0100
committerJán Tomko <jtomko@redhat.com>2016-02-11 08:05:16 +0100
commit28e5655de3e465cb0faaaf2b35aec7f1c31bbe52 (patch)
treed38407b0c242f98df9ef2988ed6123461e340969 /cfg.mk
parent4d569245f0f178927a0d503695e5e1573f7d6b97 (diff)
downloadlibvirt-28e5655de3e465cb0faaaf2b35aec7f1c31bbe52.tar.gz
Prohibit verbose strcat
Using strcat directly is more readable than passing strlen of the copied string to strncat.
Diffstat (limited to 'cfg.mk')
-rw-r--r--cfg.mk6
1 files changed, 6 insertions, 0 deletions
diff --git a/cfg.mk b/cfg.mk
index 71b0866d52..3f78842a5b 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -1031,6 +1031,12 @@ sc_prohibit_not_strneq:
halt='Use STREQ instead of !STRNEQ' \
$(_sc_search_regexp)
+sc_prohibit_verbose_strcat:
+ @prohibit='strncat\([^,]*,\s+([^,]*),\s+strlen\(\1\)\)' \
+ in_vc_files='\.[ch]$$' \
+ halt='Use strcat(a, b) instead of strncat(a, b, strlen(b))' \
+ $(_sc_search_regexp)
+
# We don't use this feature of maint.mk.
prev_version_file = /dev/null