diff options
| author | Pavel Hrdina <phrdina@redhat.com> | 2020-07-17 21:09:25 +0200 |
|---|---|---|
| committer | Pavel Hrdina <phrdina@redhat.com> | 2020-08-03 09:27:09 +0200 |
| commit | 942d377d25ab2be8be36a172789c2d2127b5236a (patch) | |
| tree | 503b5677e2f253ba8ae00234ec767d0dd83e3720 /docs/committer-guidelines.rst | |
| parent | 7e5d771d1747ab00235f392baa559b9b00b16f35 (diff) | |
| download | libvirt-942d377d25ab2be8be36a172789c2d2127b5236a.tar.gz | |
meson: adjust our documentation to mention meson instead of autoconf
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
Diffstat (limited to 'docs/committer-guidelines.rst')
| -rw-r--r-- | docs/committer-guidelines.rst | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/docs/committer-guidelines.rst b/docs/committer-guidelines.rst index 3be08e6fed..d2c530d895 100644 --- a/docs/committer-guidelines.rst +++ b/docs/committer-guidelines.rst @@ -12,8 +12,8 @@ objection on the list it should be good to go. If the patch touches a part of the code where you're not the main maintainer, or where you do not have a very clear idea of how things work, it's better to wait for a more authoritative feedback though. -Before committing, please also rebuild locally, run 'make check -syntax-check', and make sure you don't raise errors. +Before committing, please also rebuild locally, run 'ninja test', +and make sure you don't raise errors. An exception to 'review and approval on the list first' is fixing failures to build: @@ -21,11 +21,10 @@ failures to build: - if a recently committed patch breaks compilation on a platform or for a given driver, then it's fine to commit a minimal fix directly without getting the review feedback first -- if make check or make syntax-check breaks, if there is an - obvious fix, it's fine to commit immediately. The patch should - still be sent to the list (or tell what the fix was if - trivial), and 'make check syntax-check' should pass too, before - committing anything +- if ninja test breaks, if there is an obvious fix, it's fine to + commit immediately. The patch should still be sent to the list + (or tell what the fix was if trivial), and 'ninja test' should + pass too, before committing anything - fixes for documentation and code comments can be managed in the same way, but still make sure they get reviewed if non-trivial. - (ir)regular pulls from other repositories or automated updates, |