diff options
| author | Kristina Hanicova <khanicov@redhat.com> | 2022-09-05 15:57:05 +0200 |
|---|---|---|
| committer | Ján Tomko <jtomko@redhat.com> | 2022-09-07 12:13:30 +0200 |
| commit | 0d22febfc6bd984162a789aac6a4a55f42c2c6b9 (patch) | |
| tree | c921ecf7093054478da948243b82d06544f6d5a0 /docs/kbase | |
| parent | 0150f7a8c1d87d58367d460787460a4d4f1e0151 (diff) | |
| download | libvirt-0d22febfc6bd984162a789aac6a4a55f42c2c6b9.tar.gz | |
qemu: use virDomainObjBeginJob()
This patch moves qemuDomainObjBeginJob() into
src/conf/virdomainjob as universal virDomainObjBeginJob().
Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Diffstat (limited to 'docs/kbase')
| -rw-r--r-- | docs/kbase/internals/qemu-threads.rst | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/docs/kbase/internals/qemu-threads.rst b/docs/kbase/internals/qemu-threads.rst index c68512d1b3..00340bb732 100644 --- a/docs/kbase/internals/qemu-threads.rst +++ b/docs/kbase/internals/qemu-threads.rst @@ -62,7 +62,7 @@ There are a number of locks on various objects Agent job condition is then used when thread wishes to talk to qemu agent monitor. It is possible to acquire just agent job - (``qemuDomainObjBeginAgentJob``), or only normal job (``qemuDomainObjBeginJob``) + (``qemuDomainObjBeginAgentJob``), or only normal job (``virDomainObjBeginJob``) but not both at the same time. Holding an agent job and a normal job would allow an unresponsive or malicious agent to block normal libvirt API and potentially result in a denial of service. Which type of job to grab @@ -114,7 +114,7 @@ To lock the ``virDomainObj`` To acquire the normal job condition - ``qemuDomainObjBeginJob()`` + ``virDomainObjBeginJob()`` - Waits until the job is compatible with current async job or no async job is running - Waits for ``job.cond`` condition ``job.active != 0`` using ``virDomainObj`` @@ -214,7 +214,7 @@ Design patterns obj = qemuDomObjFromDomain(dom); - qemuDomainObjBeginJob(obj, VIR_JOB_TYPE); + virDomainObjBeginJob(obj, VIR_JOB_TYPE); ...do work... @@ -230,7 +230,7 @@ Design patterns obj = qemuDomObjFromDomain(dom); - qemuDomainObjBeginJob(obj, VIR_JOB_TYPE); + virDomainObjBeginJob(obj, VIR_JOB_TYPE); ...do prep work... |