diff options
author | Peter Krempa <pkrempa@redhat.com> | 2022-05-26 14:58:19 +0200 |
---|---|---|
committer | Peter Krempa <pkrempa@redhat.com> | 2022-07-26 16:35:57 +0200 |
commit | 80e50315b45d1dbeb44025a697caf212700d3931 (patch) | |
tree | fec2bfc8476316945ed47f7e8a703217a2e53987 /docs | |
parent | 06a9dcb35d620f062de0ad65b888bad2c6982205 (diff) | |
download | libvirt-80e50315b45d1dbeb44025a697caf212700d3931.tar.gz |
docs: patches: Add a note about reviews and contacting developers
Add a note outling best practices around review and responding to it.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Diffstat (limited to 'docs')
-rw-r--r-- | docs/submitting-patches.rst | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index 7bc22323ee..4cae82c771 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -89,3 +89,24 @@ Moreover, such patch needs to be prefixed correctly with ``--subject-prefix=PATCHv2`` appended to ``git send-email`` (substitute ``v2`` with the correct version if needed though). + +Review process +-------------- + +Reviewing patches may take a lot of effort with review bandwidth being limited +in open source projects. Here are a few rules to follow to streamline the +process: + + - **don't** contact individual maintainers/developers directly with your + patches; reviewers are subscribed to the mailing list + - **do** be patient; reviewers may be busy + - **do** respond to reviewer's questions + - **don't** ignore a suggestion from a reviewer; if you disagree discuss it on + the list before sending a new version + - **do** remind us of your patches on the list if they haven't gotten any + attention for a prolonged period (>1 week) by replying to your patches with a + "ping" + - **do** test your patches before sending + +Don't feel obliged to review whole patch series if you see any major problems +in any of the comprising patches - just point them out on the list. |