diff options
author | Michal Privoznik <mprivozn@redhat.com> | 2021-11-08 13:33:09 +0100 |
---|---|---|
committer | Michal Privoznik <mprivozn@redhat.com> | 2021-11-12 17:17:16 +0100 |
commit | a4056d52eb99afcd7bb30e36f946f65b40dc6c86 (patch) | |
tree | afaf0d68c0ea81d63bdae4aaa0df8093d6754682 /examples | |
parent | 132069f845b67cc45715c081527950a4e03e2a47 (diff) | |
download | libvirt-a4056d52eb99afcd7bb30e36f946f65b40dc6c86.tar.gz |
examples/dommigrate: Make retval portable
Currently, the dommigrate example returns 0 or 1 for success or
failure state, respectively. Except for a few cases where it
forgot to change the @ret variable just before jumping onto the
'cleanup' label. Making the code follow our usual pattern
(initialize @ret to an error value and set it to success value
only at the end) fixes those cases. Also, using EXIT_SUCCESS and
EXIT_FAILURE is more portable (even though on my system they are
just an alias to values the example already uses).
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Kristína Hanicová <khanicov@redhat.com>
Diffstat (limited to 'examples')
-rw-r--r-- | examples/c/domain/dommigrate.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/examples/c/domain/dommigrate.c b/examples/c/domain/dommigrate.c index b1641efb9a..3d32ada6d3 100644 --- a/examples/c/domain/dommigrate.c +++ b/examples/c/domain/dommigrate.c @@ -36,7 +36,7 @@ int main(int argc, char *argv[]) { char *src_uri, *dst_uri, *domname; - int ret = 0; + int ret = EXIT_FAILURE; virConnectPtr conn = NULL; virDomainPtr dom = NULL; @@ -52,7 +52,6 @@ main(int argc, char *argv[]) printf("Attempting to connect to the source hypervisor...\n"); conn = virConnectOpenAuth(src_uri, virConnectAuthPtrDefault, 0); if (!conn) { - ret = 1; fprintf(stderr, "No connection to the source hypervisor: %s.\n", virGetLastErrorMessage()); goto out; @@ -74,6 +73,7 @@ main(int argc, char *argv[]) } printf("Migration finished with success.\n"); + ret = EXIT_SUCCESS; cleanup: if (dom != NULL) |