summaryrefslogtreecommitdiff
path: root/src/ch
diff options
context:
space:
mode:
authorMichal Privoznik <mprivozn@redhat.com>2022-02-10 15:58:12 +0100
committerMichal Privoznik <mprivozn@redhat.com>2022-02-11 10:48:32 +0100
commit3d13f6abcd9a031c4e1d8c7a592c4c3df38903b4 (patch)
treef9014253737949d0f9a88f89647bdc7690190177 /src/ch
parentb928e0d80c902b2841aee0a3660de7e4b3868083 (diff)
downloadlibvirt-3d13f6abcd9a031c4e1d8c7a592c4c3df38903b4.tar.gz
ch_driver: End job properly on failed chDomainCreateXML()
When creating a domain failed, then the virCHDomainObjEndJob() would be jumped over. Fix this by creating enjob label and fixing one goto. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
Diffstat (limited to 'src/ch')
-rw-r--r--src/ch/ch_driver.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
index b023f7e3d3..cd156a222b 100644
--- a/src/ch/ch_driver.c
+++ b/src/ch/ch_driver.c
@@ -228,10 +228,11 @@ chDomainCreateXML(virConnectPtr conn,
goto cleanup;
if (virCHProcessStart(driver, vm, VIR_DOMAIN_RUNNING_BOOTED) < 0)
- goto cleanup;
+ goto endjob;
dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id);
+ endjob:
virCHDomainObjEndJob(vm);
cleanup: