diff options
| author | Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> | 2016-02-17 15:14:58 +0300 |
|---|---|---|
| committer | Daniel P. Berrange <berrange@redhat.com> | 2016-03-01 14:16:56 +0000 |
| commit | fa8c1645015af04e0838f71e573115c1c472d471 (patch) | |
| tree | 3f0cbe50bb377e1325d631f96edd70c316699a90 /src/libvirt-host.c | |
| parent | baf47a1f5a9a42ec552dae9505f0de10f1fc2277 (diff) | |
| download | libvirt-fa8c1645015af04e0838f71e573115c1c472d471.tar.gz | |
close callback API: remove unnecessary locks
closeCallback pointer is immutable (set on connection object creation)
and self-locking.
Diffstat (limited to 'src/libvirt-host.c')
| -rw-r--r-- | src/libvirt-host.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/libvirt-host.c b/src/libvirt-host.c index ced6a549a2..b0597ee2fb 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -1214,10 +1214,7 @@ virConnectRegisterCloseCallback(virConnectPtr conn, VIR_DEBUG("conn=%p", conn); virResetLastError(); - virCheckConnectReturn(conn, -1); - virObjectLock(conn); - virCheckNonNullArgGoto(cb, error); if (virConnectCloseCallbackDataGetCallback(conn->closeCallback) != NULL) { @@ -1229,11 +1226,9 @@ virConnectRegisterCloseCallback(virConnectPtr conn, virConnectCloseCallbackDataRegister(conn->closeCallback, conn, cb, opaque, freecb); - virObjectUnlock(conn); return 0; error: - virObjectUnlock(conn); virDispatchError(conn); return -1; } @@ -1259,10 +1254,7 @@ virConnectUnregisterCloseCallback(virConnectPtr conn, VIR_DEBUG("conn=%p", conn); virResetLastError(); - virCheckConnectReturn(conn, -1); - virObjectLock(conn); - virCheckNonNullArgGoto(cb, error); if (virConnectCloseCallbackDataGetCallback(conn->closeCallback) != cb) { @@ -1273,11 +1265,9 @@ virConnectUnregisterCloseCallback(virConnectPtr conn, virConnectCloseCallbackDataUnregister(conn->closeCallback, cb); - virObjectUnlock(conn); return 0; error: - virObjectUnlock(conn); virDispatchError(conn); return -1; } |