summaryrefslogtreecommitdiff
path: root/src/rpc/virnetserverservice.c
diff options
context:
space:
mode:
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>2020-07-09 10:59:33 +0300
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>2020-09-07 09:33:58 +0300
commit1eae52b9f1f2c0232d14e0effa47e8e6e5cce28d (patch)
treee678625b9d3f96b57b1ea7c709f6ddd678cad395 /src/rpc/virnetserverservice.c
parent255437eeb710d8135136af11b37ceae674d483ce (diff)
downloadlibvirt-1eae52b9f1f2c0232d14e0effa47e8e6e5cce28d.tar.gz
rpc: don't unref service ref on socket behalf twice
Second unref was added in [1]. We don't need it actually as we pass free callback to virNetSocketAddIOCallback thus when we call virNetSocketRemoveIOCallback the extra ref for callback will be dropped without extra efforts. [1] 355d8f470f9: virNetServerServiceClose: Don't leak sockets Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Diffstat (limited to 'src/rpc/virnetserverservice.c')
-rw-r--r--src/rpc/virnetserverservice.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/rpc/virnetserverservice.c b/src/rpc/virnetserverservice.c
index 9d5df456a8..e4165eacb7 100644
--- a/src/rpc/virnetserverservice.c
+++ b/src/rpc/virnetserverservice.c
@@ -449,6 +449,5 @@ void virNetServerServiceClose(virNetServerServicePtr svc)
for (i = 0; i < svc->nsocks; i++) {
virNetSocketRemoveIOCallback(svc->socks[i]);
virNetSocketClose(svc->socks[i]);
- virObjectUnref(svc);
}
}