diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2021-02-16 12:18:55 +0000 |
|---|---|---|
| committer | Daniel P. Berrangé <berrange@redhat.com> | 2021-02-16 14:03:13 +0000 |
| commit | 0d981fcd9754397b11b923ed10209239533f9e86 (patch) | |
| tree | ec304a96426974a68d4c164bb32cc7361533e870 /src/util/virqemu.c | |
| parent | 8851d8755626abedd3935c1947b8f2752108bd7b (diff) | |
| download | libvirt-0d981fcd9754397b11b923ed10209239533f9e86.tar.gz | |
qemu: use on|off instead of yes|no for -drive boolean properties
QEMU has long accepted many different values for boolean properties, but
set accepted has been different depending on which QEMU parser you hit.
The on|off values were supported by all QEMU parsers. The yes|no, y|n,
true|false values were only partially supported:
https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg01012.html
Thus we should standardize on on|off everywhere since that is most
widely supported in QEMU.
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'src/util/virqemu.c')
| -rw-r--r-- | src/util/virqemu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/util/virqemu.c b/src/util/virqemu.c index 4136012c70..5b0dc25bc1 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@ -362,7 +362,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, false, + if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, true, virQEMUBuildCommandLineJSONArrayNumbered) < 0) return NULL; |