diff options
author | Daniel P. Berrange <berrange@redhat.com> | 2013-09-25 15:37:10 +0100 |
---|---|---|
committer | Daniel P. Berrange <berrange@redhat.com> | 2013-09-25 18:12:09 +0100 |
commit | b32ac57ee5e0519283efa40f6196ba1fce2e753d (patch) | |
tree | 5b7fb0582a8cc22e49430290792fd8783afecc32 /tests/virnetmessagetest.c | |
parent | a93eb09a971f191e0ee91a8611ac976d71077987 (diff) | |
download | libvirt-b32ac57ee5e0519283efa40f6196ba1fce2e753d.tar.gz |
Avoid use of uninitialized data in virnetmessagetest
If an error occurs in virnetmessagetest it was possible it
would free uninitialized data.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Diffstat (limited to 'tests/virnetmessagetest.c')
-rw-r--r-- | tests/virnetmessagetest.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c index 3c9bead5d3..eabc609501 100644 --- a/tests/virnetmessagetest.c +++ b/tests/virnetmessagetest.c @@ -327,6 +327,8 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED) }; int ret = -1; + memset(&err, 0, sizeof(err)); + if (!msg) return -1; @@ -334,7 +336,6 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED) if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0) goto cleanup; memcpy(msg->buffer, input_buffer, msg->bufferLength); - memset(&err, 0, sizeof(err)); if (virNetMessageDecodeLength(msg) < 0) { VIR_DEBUG("Failed to decode message header"); |