diff options
| author | Kristina Hanicova <khanicov@redhat.com> | 2021-03-24 17:47:44 +0100 |
|---|---|---|
| committer | Ján Tomko <jtomko@redhat.com> | 2021-04-01 13:36:35 +0200 |
| commit | 6336fcd9f82e4d75f85ccfe22b9b8f5bb3df4fd4 (patch) | |
| tree | 100ac80a79496c3d6d7ad753038f19308b1cccc5 /tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml | |
| parent | 65c371fc69f59b6d0e5c3cc8fe7735dc5788eb79 (diff) | |
| download | libvirt-6336fcd9f82e4d75f85ccfe22b9b8f5bb3df4fd4.tar.gz | |
XML <source bridge='VMnet0'/> update in <interface type='bridge'/>
Previously, we accepted empty bridge name, because some old versions of
VMWare Workstation did not put it into the config. But this doesn't make
much sense - to have an interface type bridge with no name. We
circumvented this problem by generating an empty name but that is
equally wrong.
Therefore, fill in missing bridge names (according to the documentation
[1] the default bridge name is VMnet0) and error out if bridge name is
missing.
This partially reverts f246cdb5aca13ac9409b2ad43087e3078615ffcb
1: https://docs.vmware.com/en/VMware-Workstation-Player-for-Linux/16.0/com.vmware.player.linux.using.doc/GUID-BAFA66C3-81F0-4FCA-84C4-D9F7D258A60A.html
Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Diffstat (limited to 'tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml')
| -rw-r--r-- | tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml b/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml index 30fb76c818..2bf8699149 100644 --- a/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml +++ b/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml @@ -20,7 +20,7 @@ <controller type='scsi' index='0' model='lsilogic'/> <interface type='bridge'> <mac address='00:90:b9:dc:ea:81'/> - <source bridge=''/> + <source bridge='VMnet0'/> <model type='e1000'/> </interface> <video> |