diff options
| author | James Zern <jzern@google.com> | 2023-04-17 13:42:11 -0700 |
|---|---|---|
| committer | James Zern <jzern@google.com> | 2023-05-09 14:04:19 -0700 |
| commit | 9e0fc37f6f68685066f3e71e1cd0605d6ee2205e (patch) | |
| tree | dcde7ade01a01d8476795a855839fca3c516f0c9 | |
| parent | 894262fb8fe137401d56586b7998711cf49ebe24 (diff) | |
| download | libvpx-9e0fc37f6f68685066f3e71e1cd0605d6ee2205e.tar.gz | |
configure: add -Wshadow
libraries under third_party/ are out of scope for this change.
Bug: webm:1793
Change-Id: I562065a3c0ea9fdfc9615d1a6b1ae47da79b8ce0
| -rw-r--r-- | build/make/configure.sh | 1 | ||||
| -rwxr-xr-x | configure | 6 | ||||
| -rw-r--r-- | examples.mk | 1 | ||||
| -rw-r--r-- | test/test.mk | 1 |
4 files changed, 8 insertions, 1 deletions
diff --git a/build/make/configure.sh b/build/make/configure.sh index ec9af5e63..6fd67f162 100644 --- a/build/make/configure.sh +++ b/build/make/configure.sh @@ -521,6 +521,7 @@ AS_SFX = ${AS_SFX:-.asm} EXE_SFX = ${EXE_SFX} VCPROJ_SFX = ${VCPROJ_SFX} RTCD_OPTIONS = ${RTCD_OPTIONS} +LIBWEBM_CXXFLAGS = ${LIBWEBM_CXXFLAGS} LIBYUV_CXXFLAGS = ${LIBYUV_CXXFLAGS} EOF @@ -649,6 +649,7 @@ process_toolchain() { check_add_cflags -Wimplicit-function-declaration check_add_cflags -Wmissing-declarations check_add_cflags -Wmissing-prototypes + check_add_cflags -Wshadow check_add_cflags -Wuninitialized check_add_cflags -Wunreachable-code-loop-increment check_add_cflags -Wunused @@ -679,13 +680,16 @@ process_toolchain() { check_add_cxxflags -Wc++17-extensions check_add_cxxflags -Wc++20-extensions - # disable some warnings specific to libyuv. + # disable some warnings specific to libyuv / libwebm. check_cxxflags -Wno-missing-declarations \ && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-missing-declarations" check_cxxflags -Wno-missing-prototypes \ && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-missing-prototypes" check_cxxflags -Wno-pass-failed \ && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-pass-failed" + check_cxxflags -Wno-shadow \ + && LIBWEBM_CXXFLAGS="${LIBWEBM_CXXFLAGS} -Wno-shadow" \ + && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-shadow" check_cxxflags -Wno-unused-parameter \ && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-unused-parameter" fi diff --git a/examples.mk b/examples.mk index 42886f1e1..9e506dcd4 100644 --- a/examples.mk +++ b/examples.mk @@ -57,6 +57,7 @@ LIBWEBM_PARSER_SRCS = third_party/libwebm/mkvparser/mkvparser.cc \ # Add compile flags and include path for libwebm sources. ifeq ($(CONFIG_WEBM_IO),yes) CXXFLAGS += -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS + $(BUILD_PFX)third_party/libwebm/%.cc.o: CXXFLAGS += $(LIBWEBM_CXXFLAGS) INC_PATH-yes += $(SRC_PATH_BARE)/third_party/libwebm endif diff --git a/test/test.mk b/test/test.mk index bbcdd0c6e..b64e89bb4 100644 --- a/test/test.mk +++ b/test/test.mk @@ -85,6 +85,7 @@ LIBVPX_TEST_SRCS-$(CONFIG_DECODERS) += ../webmdec.cc LIBVPX_TEST_SRCS-$(CONFIG_DECODERS) += ../webmdec.h LIBVPX_TEST_SRCS-$(CONFIG_DECODERS) += webm_video_source.h LIBVPX_TEST_SRCS-$(CONFIG_VP9_DECODER) += vp9_skip_loopfilter_test.cc +$(BUILD_PFX)third_party/libwebm/%.cc.o: CXXFLAGS += $(LIBWEBM_CXXFLAGS) endif LIBVPX_TEST_SRCS-$(CONFIG_DECODERS) += decode_api_test.cc |