| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://yaml.org/spec/1.1/#id907281
The question mark isn't mentioned as something special here, only
,[]{}
This commit will allow
[foo?bar]
[foo ? bar]
The PR does only change the behaviour when the question mark is in the middle or
at the end of the string, not at the beginning, e.g. [?foo] is handled by
a different part of the code.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See issue #46
Passing emitter tests:
* 2XXW: Spec Example 2.25. Unordered Sets
* 5WE3: Spec Example 8.17. Explicit Block Mapping Entries
* 6KGN: Anchor for empty node
* 6XDY: Two document start markers
* 7W2P: Block Mapping with Missing Values
* 8KB6: Multiline plain flow mapping key without value
* 9BXH: Multiline doublequoted flow mapping key without value
* C2DT: Spec Example 7.18. Flow Mapping Adjacent Values
* JTV5: Block Mapping with Multiline Scalars
* KK5P: Various combinations of explicit block mappings
* LE5A: Spec Example 7.24. Flow Nodes
* UT92: Spec Example 9.4. Explicit Documents
* W42U: Spec Example 8.15. Block Sequence Entry Types
* W4TN: Spec Example 9.5. Directives Documents
* ZWK4: Key with anchor after missing explicit mapping value
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
a: &b x
*b: c
Now:
a: &b x
*b : c
Passing tests:
* 26DV: Whitespace around colon in mappings
* E76Z: Aliases in Implicit Block Mapping
* X38W: Aliases in Flow Objects
Test manually because `make test-suite` will overwrite changes in the skiplist:
./tests/run-parser-test-suite tests/run-test-suite/data/26DV/in.yaml | ./tests/run-emitter-test-suite
./tests/run-parser-test-suite tests/run-test-suite/data/E76Z/in.yaml | ./tests/run-emitter-test-suite
./tests/run-parser-test-suite tests/run-test-suite/data/X38W/in.yaml | ./tests/run-emitter-test-suite
Or edit tests/run-test-suite/test/blacklist/libyaml-emitter and do:
(cd tests/run-test-suite; prove -lv test)
Also I added some newlines to yaml.h to help identifying states by number.
|
|
|
|
| |
Spec: https://yaml.org/spec/1.2/spec.html#ns-tag-char
Test: https://github.com/yaml/yaml-test-suite/blob/master/test/WZ62.tml
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
open_ended can have three states now:
0: The previous document was ended explicitly with '...'
1: The previous document wasn't ended with '...'
2: The last scalar event was a block scalar with trailing empty lines |+, and
last document wasn't ended with '...'.
Important at stream end.
This was broken in the past, and fixed in fa1293a.
With my last PR #162 I added the faulty behaviour again.
The problematic behaviour showed only when all of the following conditions were
true:
* writing YAML directives
* writing unquoted top level scalars
* writing more than one document
================== BROKEN ==============================
The first example shows that the document end marker is not emitted before
the next document. This would be valid in YAML 1.1 if the scalar was quoted,
but not if it is plain.
This commit fixes this.
echo '--- foo
--- bar
' | ./tests/run-parser-test-suite | ./tests/run-emitter-test-suite --directive 1.1
%YAML 1.1
--- foo
%YAML 1.1
--- bar
================== FIXED ==============================
echo '--- foo
--- bar
' | ./tests/run-parser-test-suite | ./tests/run-emitter-test-suite --directive 1.1
%YAML 1.1
--- foo
...
%YAML 1.1
--- bar
=======================================================
Other examples which should look like this (and were correct already before
this fix):
Open ended scalars like |+ need '...' at the end of the stream:
echo '--- |+
a
--- |+
a
' | ./tests/run-parser-test-suite | ./tests/run-emitter-test-suite
--- |+
a
--- |+
a
...
=======================================================
If a document is ended with an explicit '...', the code should not
print '...' twice:
echo '--- foo
...
--- bar
' | ./tests/run-parser-test-suite | ./tests/run-emitter-test-suite --directive 1.1
%YAML 1.1
--- foo
...
%YAML 1.1
--- bar
==========================================================
|
|
|
|
|
|
|
|
| |
Before `1.1` was hardcoded in the emitter.
* Also add --directive option to run-emitter-test-suite
Allows to easily test how output looks like if %YAML directives
are output.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will simply allow `%YAML 1.2` directives additionally to `%YAML 1.1`.
There is no change in behaviour.
See also #20
No changes are needed regarding tag directives.
In YAML 1.2 tag directives are for the following document only.
This is already implemented like that in libyaml.
We would rather have to fix the code if we want to have the correct behaviour
(global directives) in YAML 1.1. This would be a bit more complicated, as we
would have to save the default version and the current version in the parser
object.
New passing parser tests:
* 27NA: Spec Example 5.9. Directive Indicator
* 6ZKB: Spec Example 9.6. Stream
* 9DXL: Spec Example 9.6. Stream [1.3]
* RTP8: Spec Example 9.2. Document Markers
New failing error parser tests (before they were errors for the wrong reason):
* EB22: Missing document-end marker before directive
* RHX7: YAML directive without document end marker
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The document loading API (yaml_parser_load) was susseptable to a
stack overflow issue when given input data which opened many
mappings and/or sequences without closing them.
This was due to the use of recurion in the implementation.
With this change, we avoid recursion, and maintain our own loader
context stack on the heap.
The loader context contains a stack of document node indexes.
Each time a sequence or mapping start event is encountered,
the node index corrasponding to the event is pushed to the
stack. Each time a sequence or mapping end event is encountered,
the corrasponding node's index is popped from the stack.
The yaml_parser_load_nodes() function sits on the event stream,
issuing events to the appropriate handlers by type.
When an event handler function constructs a node, it needs to
connect the new node to its parent (unless it's the root node).
This is where the loader context stack is used to find the
parent node. The way that the new node is added to the tree
depends on whether the parent node is a mapping (with a
yaml_node_pair_t to fill), or a sequence (with a yaml_node_item_t).
Fixes: https://github.com/yaml/libyaml/issues/107
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In YAML 1.1, the document end marker `...` is optional even if the next document starts with a directive:
https://github.com/yaml/pyyaml/blob/master/tests/data/spec-07-09.canonical
```
%YAML 1.1
---
!!str "foo"
%YAML 1.1
---
!!str "bar"
%YAML 1.1
---
!!str "baz"
```
It is only required if the scalar is "open ended", for example for plain scalars.
In YAML 1.2 the `...` marker is always required before a directive.
My suggestion would be to make the output 1.2 compatible. It will still be 1.1 compatible, so that shouldn't be a problem.
I believe this will also make it easier to fix #123 which was introduced with the last fixes regarding `open_ended`. I think I can make a fix for this soon after this issue is fixed.
Fixing #123 without this would be a bit more complicated.
If we do this, we also need to adjust PyYAML to behave the same.
Related issues/commits:
- https://github.com/yaml/libyaml/issues/60
- https://github.com/yaml/libyaml/pull/122
- 56400d9, 8ee83c0, 56f4b17
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'config.h' is meant to be a convenience header to be #included at build
time, but not installed. Installing it can cause a host of problems for
various other projects (for instance, attempting to build u-boot from
source while another project's 'config.h' exists in the compiler search
path will cause build failures similar to:
https://github.com/pepe2k/u-boot_mod/issues/148
Further, I've changed '#include <config.h>' to '#include "config.h"',
which should constrain the search path to the current build directories,
so if another package with a bugged build has this file installed, it
will not cause yaml to miscompile/fail.
If you have a file `/usr/include/config.h` on your filesystem, query
your package manager to find out what package owns it, and file a bug
report against it with your distro maintainers.
Signed-off-by: Marty E. Plummer <hanetzer@protonmail.com>
|
|
|
|
| |
Thanks to @tlsa for spotting this
|
|
|
|
| |
detected by coverity
|
| |
|
|
|
|
| |
yaml_emitter_write_indicator const char *indicator
|
|
|
|
| |
Commit amended by @perlpunk after suggestion from @tlsa
|
|
|
|
|
| |
we cannot malloc to an anon struct in C++.
typedef yaml_anchors_t
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup to #28
See http://yaml.org/spec/1.1/#nb-plain-char(c) and the following
productions.
This commit will allow `[http://example]`, but still fail for:
- `[:foo]`
- `[foo:]`
See https://gist.github.com/perlpunk/de2c631a7b0e9002de351a680eadb573
for all the relevant cases where this change applies.
|
|
|
|
| |
Remove unneeded context, which is not set in any macro.
|
|
|
| |
nessesary to necessary
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if it's on its own line.
```
% cd libyaml
% echo "+STR
+DOC
+SEQ
=VAL '\\\n
-SEQ
-DOC
-STR" | ./tests/run-emitter-test-suite
- '
'
% # fix
% make
...
% echo "+STR
+DOC
+SEQ
=VAL '\\\n
-SEQ
-DOC
-STR" | ./tests/run-emitter-test-suite
- '
'
```
|
| |
|
|
|
|
|
|
|
|
| |
(only when explicitly requested)
@jrtc27++ for the patch.
See #60
|
|
|
|
|
|
|
|
| |
See also issue #60
Revert "This code is not needed and breaks tests"
This reverts commit 56400d976a1999156b1abfd674c3122843980260.
|
|
|
|
| |
It's just as easy to calculate the maximum value directly.
|
|
|
|
|
|
|
|
|
|
|
| |
repro:
CFLAGS="-Wall -Wextra -Wunused-parameter -Wc++-compat" ./configure && make
which we use for perl, and libyaml is now included in cperl.
Tested with gcc-5 and clang-3.7
There are still a tons of format warnings (%d on 64bit) in
example-deconstructor.c which I skipped.
|
|
|
|
| |
From https://github.com/ingydotnet/yaml-libyaml-pm/issues/24
|
|
|
|
|
|
|
|
| |
Without this change building a dll with the mingw-w64 toolchain is
impossible. All tests from make test-all succeed on native linux
(Gentoo amd64 glibc default/linux/amd64/17.1/desktop gcc-7.2.0)
Signed-off-by: Marty E. Plummer <hanetzer@protonmail.com>
|
|
|
|
| |
Seems to be the case on HP-UX
|
|
|
|
| |
See also issue #68
|
|
|
|
|
|
|
| |
Google's OSS Fuzz project found input for libyaml that was capable of
triggering an uninitialized value crash.
Patch provided by Alex Gaynor
|
|
|
|
|
| |
Let's start warning on everything and we'll clean the warnings up as we
go along.
|
|
|
| |
https://en.wiktionary.org/wiki/preceed
|
| |
|
|
|
|
|
| |
See also
https://github.com/ruby/psych/commit/66fb7fb77533d0606748940288858794752d95cb
|
|
|
|
| |
Support "\/" for JSON compatability.
|
|
|
|
|
|
|
|
| |
This code was disabled in Perl binding for breaking tests.
Kirill said on IRC:
< rz> ingy: i'm not sure why i set open_ended in yaml_emitter_write_plain_scalar
|
| |
|
| |
|
|
|
|
| |
the Google Security Team).
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|