[multiple] http_method_buf()

- http_method_buf() returns (const buffer *)
- comment out unused get_http_status_name()
- inline func for http_append_method()

config processing requires a persistent buffer for method on the
off-chance that the config performed a capturing regex match in
$HTTP["method"] condition and used it later (e.g. in mod_rewrite)
(Prior behavior using r->tmp_buf was undefined in this case)

1 files changed, 1 insertions, 6 deletions

diff --git a/src/configfile-glue.c b/src/configfile-glue.c
index e0588c92..6bf1fbf7 100644
--- a/src/configfile-glue.c
+++ b/src/configfile-glue.c
@@ -541,12 +541,7 @@ static cond_result_t config_check_cond_nocache(request_st * const r, const data_
 		if (NULL == l) l = (buffer *)&empty_string;
 		break;
 	case COMP_HTTP_REQUEST_METHOD:
-		{
-			buffer * const tb = r->tmp_buf;
-			l = tb;
-			buffer_clear(tb);
-			http_method_append(tb, r->http_method);
-		}
+		l = http_method_buf(r->http_method);
 		break;
 	default:
 		return COND_RESULT_FALSE;