summaryrefslogtreecommitdiff
path: root/src/fdlog_maint.c
diff options
context:
space:
mode:
authorGlenn Strauss <gstrauss@gluelogic.com>2021-09-14 03:25:58 -0400
committerGlenn Strauss <gstrauss@gluelogic.com>2021-09-14 03:25:58 -0400
commitaf96e52be9e8d939d5cb7d83c0ee3474b80cabfe (patch)
tree349e09ada8a92b53c4ce430d579c437fb92eb721 /src/fdlog_maint.c
parent3a5704380b1291bd50fb599ab7eef5a70ff26eb2 (diff)
downloadlighttpd-git-af96e52be9e8d939d5cb7d83c0ee3474b80cabfe.tar.gz
[core] quiet coverity warnings
Diffstat (limited to 'src/fdlog_maint.c')
-rw-r--r--src/fdlog_maint.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/fdlog_maint.c b/src/fdlog_maint.c
index b71abf6c..470e5e11 100644
--- a/src/fdlog_maint.c
+++ b/src/fdlog_maint.c
@@ -281,15 +281,16 @@ fdlog_files_cycle (fdlog_st * const errh)
fdlog_st * const fdlog = fdlog_files.ptr[i];
int fd = fdlog_file_open_fd(fdlog->fn);
if (-1 != fd) {
- if (fdlog->fd != STDERR_FILENO) {
+ if (fdlog->fd > STDERR_FILENO) {
close(fdlog->fd);
fdlog->fd = fd;
}
- else if (STDERR_FILENO == dup2(fd, STDERR_FILENO))
+ else {
+ if (fdlog->fd != dup2(fd, fdlog->fd))
+ log_perror(errh, __FILE__, __LINE__,
+ "dup2() %s to %d", fdlog->fn, fdlog->fd);
close(fd);
- else
- log_perror(errh, __FILE__, __LINE__,
- "dup2() %s to STDERR", fdlog->fn);
+ }
}
else {
log_perror(errh, __FILE__, __LINE__,