diff options
| author | Filipe Manana <fdmanana@suse.com> | 2023-05-04 12:04:25 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-05-15 00:58:24 +0200 |
| commit | 37dc92b0e8145caddc1adb34fdf66add982034c3 (patch) | |
| tree | 5af6aafaf06c2a8c785e02b5e0fadeb16514923c /fs/btrfs | |
| parent | 0b51c562aea806187f7f6e6436e8b7ba43658e44 (diff) | |
| download | linux-next-37dc92b0e8145caddc1adb34fdf66add982034c3.tar.gz | |
btrfs: assert tree lock is held when linking free space
When linking a free space entry, at link_free_space(), the caller should
be holding the spinlock 'tree_lock' of the given btrfs_free_space_ctl
argument, which is necessary for manipulating the red black tree of free
space entries (done by tree_insert_offset(), which already asserts the
lock is held) and for manipulating the 'free_space', 'free_extents',
'discardable_extents' and 'discardable_bytes' counters of the given
struct btrfs_free_space_ctl.
So assert that the spinlock 'tree_lock' of the given btrfs_free_space_ctl
is held by the current task. We have multiple code paths that end up
calling link_free_space(), and all currently take the lock before calling
it.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/free-space-cache.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index f3361ebfef4a..d349ba39820a 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -1850,6 +1850,8 @@ static int link_free_space(struct btrfs_free_space_ctl *ctl, { int ret = 0; + lockdep_assert_held(&ctl->tree_lock); + ASSERT(info->bytes || info->bitmap); ret = tree_insert_offset(ctl, NULL, info); if (ret) |