summaryrefslogtreecommitdiff
path: root/modules/pam_umask
diff options
context:
space:
mode:
authorDmitry V. Levin <ldv@altlinux.org>2020-05-16 08:00:00 +0000
committerDmitry V. Levin <ldv@altlinux.org>2020-05-16 08:00:00 +0000
commitb52bd25910c9a8a32a49be7627a709a081a3768c (patch)
treec32db20bd3200b8f134d9f64883ea74c853627b7 /modules/pam_umask
parentf80ff0161f77abc84ebeee6147931f0924b9a867 (diff)
downloadlinux-pam-git-b52bd25910c9a8a32a49be7627a709a081a3768c.tar.gz
modules: do not check user name for emptyness before passing it to pam_modutil_getpwnam
pam_modutil_getpwnam is perfectly capable of handling empty strings as user names, no need to double check that. * modules/pam_access/pam_access.c (pam_sm_authenticate): Do not check the user name for emptyness before passing it to pam_modutil_getpwnam. * modules/pam_lastlog/pam_lastlog.c (pam_sm_authenticate): Likewise. * modules/pam_pwhistory/pam_pwhistory.c (pam_sm_chauthtok): Likewise. * modules/pam_shells/pam_shells.c (perform_check): Likewise. * modules/pam_tally/pam_tally.c (pam_get_uid): Likewise. * modules/pam_tally2/pam_tally2.c (pam_get_uid): Likewise. * modules/pam_umask/pam_umask.c (pam_sm_open_session): Likewise.
Diffstat (limited to 'modules/pam_umask')
-rw-r--r--modules/pam_umask/pam_umask.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/modules/pam_umask/pam_umask.c b/modules/pam_umask/pam_umask.c
index e17d0fc1..3cfe5538 100644
--- a/modules/pam_umask/pam_umask.c
+++ b/modules/pam_umask/pam_umask.c
@@ -205,12 +205,6 @@ pam_sm_open_session (pam_handle_t *pamh, int flags UNUSED,
return (retval == PAM_CONV_AGAIN ? PAM_INCOMPLETE:retval);
}
- if (name[0] == '\0')
- {
- pam_syslog (pamh, LOG_NOTICE, "bad username [%s]", name);
- return PAM_USER_UNKNOWN;
- }
-
pw = pam_modutil_getpwnam (pamh, name);
if (pw == NULL)
{