diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-01-08 16:59:07 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-01-08 15:19:55 -0800 |
| commit | 69b4ed5cbff54b8279f53a65da111e8d0cc01405 (patch) | |
| tree | 98e485b2135ccb1c9ea5e43c3d5dfa59c4545f21 | |
| parent | 90919f14507b7a3661e58b8d17f8444a63f5cafa (diff) | |
| download | linux-rt-69b4ed5cbff54b8279f53a65da111e8d0cc01405.tar.gz | |
net: sfc: use skb_list_walk_safe helper for gso segments
This is a straight-forward conversion case for the new function, and
while we're at it, we can remove a null write to skb->next by replacing
it with skb_mark_not_on_list.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/sfc/tx.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c index c9599fcab0b4..e4f0f5c94589 100644 --- a/drivers/net/ethernet/sfc/tx.c +++ b/drivers/net/ethernet/sfc/tx.c @@ -307,12 +307,9 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue, dev_consume_skb_any(skb); skb = segments; - while (skb) { - next = skb->next; - skb->next = NULL; - + skb_list_walk_safe(skb, skb, next) { + skb_mark_not_on_list(skb); efx_enqueue_skb(tx_queue, skb); - skb = next; } return 0; |