summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYoung Xiao <YangX92@hotmail.com>2019-04-12 15:24:30 +0800
committerBen Hutchings <ben@decadent.org.uk>2019-06-20 18:11:27 +0100
commitacaf43aa7ede1e500532f1f5d910e207f89d5e1f (patch)
treebc08ae7c8895ddde4db5a5fb0bdc341c6e962f11
parent13c4be25bdcbe5045f9b17ad875c3253a4888e45 (diff)
downloadlinux-rt-acaf43aa7ede1e500532f1f5d910e207f89d5e1f.tar.gz
Bluetooth: hidp: fix buffer overflow
commit a1616a5ac99ede5d605047a9012481ce7ff18b16 upstream. Struct ca is copied from userspace. It is not checked whether the "name" field is NULL terminated, which allows local users to obtain potentially sensitive information from kernel stack memory, via a HIDPCONNADD command. This vulnerability is similar to CVE-2011-1079. Signed-off-by: Young Xiao <YangX92@hotmail.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--net/bluetooth/hidp/sock.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/bluetooth/hidp/sock.c b/net/bluetooth/hidp/sock.c
index cb3fdde1968a..322047f9d038 100644
--- a/net/bluetooth/hidp/sock.c
+++ b/net/bluetooth/hidp/sock.c
@@ -76,6 +76,7 @@ static int hidp_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long
sockfd_put(csock);
return err;
}
+ ca.name[sizeof(ca.name)-1] = 0;
err = hidp_connection_add(&ca, csock, isock);
if (!err && copy_to_user(argp, &ca, sizeof(ca)))