summaryrefslogtreecommitdiff
path: root/drivers/crypto
diff options
context:
space:
mode:
authorMario Limonciello <mario.limonciello@amd.com>2023-04-03 13:32:10 -0500
committerHerbert Xu <herbert@gondor.apana.org.au>2023-04-14 18:59:34 +0800
commitcfd7ca021e561d4d908d876692debd95cac69dc2 (patch)
tree171e9e18693d40d3f7c537fa0b8690bb0ce46642 /drivers/crypto
parentc79a3169b9f3633c215b55857eba5921e5b49217 (diff)
downloadlinux-stable-cfd7ca021e561d4d908d876692debd95cac69dc2.tar.gz
crypto: ccp - Drop extra doorbell checks
The doorbell register set used for I2C arbitration is dedicated for this purpose and there is no need to utilize other safety checks the platform access register set uses. Suggested-by: Mark Hasemeyer <markhas@chromium.org> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Mark Hasemeyer <markhas@chromium.org> Tested-by: Mark Hasemeyer <markhas@chromium.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r--drivers/crypto/ccp/platform-access.c20
1 files changed, 0 insertions, 20 deletions
diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c
index b51fb1196932..1ad3a0a512b1 100644
--- a/drivers/crypto/ccp/platform-access.c
+++ b/drivers/crypto/ccp/platform-access.c
@@ -20,14 +20,6 @@
#define PSP_CMD_TIMEOUT_US (500 * USEC_PER_MSEC)
-/* Doorbell shouldn't be ringing */
-static int check_doorbell(u32 __iomem *doorbell)
-{
- u32 tmp;
-
- return readl_poll_timeout(doorbell, tmp, tmp != 0, 0, PSP_CMD_TIMEOUT_US);
-}
-
/* Recovery field should be equal 0 to start sending commands */
static int check_recovery(u32 __iomem *cmd)
{
@@ -156,18 +148,6 @@ int psp_ring_platform_doorbell(int msg)
mutex_lock(&pa_dev->doorbell_mutex);
- if (check_doorbell(button)) {
- dev_dbg(psp->dev, "doorbell is not ready\n");
- ret = -EBUSY;
- goto unlock;
- }
-
- if (check_recovery(cmd)) {
- dev_dbg(psp->dev, "doorbell command in recovery\n");
- ret = -EBUSY;
- goto unlock;
- }
-
if (wait_cmd(cmd)) {
dev_dbg(psp->dev, "doorbell command not done processing\n");
ret = -EBUSY;