diff options
| author | Masami Hiramatsu <mhiramat@kernel.org> | 2019-11-26 17:34:42 +0900 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2019-12-09 10:53:04 -0700 |
| commit | 5cc6c8d4a99d0ee4d5466498e258e593df1d3eb6 (patch) | |
| tree | 9ea6bbe3b610fc8bd91e4fa9eb95403452eba8f4 | |
| parent | ba1b9c5048e43716921abe3a1db19cebebf4a5f5 (diff) | |
| download | linux-5cc6c8d4a99d0ee4d5466498e258e593df1d3eb6.tar.gz | |
selftests/ftrace: Fix multiple kprobe testcase
Fix multiple kprobe event testcase to work it correctly.
There are 2 bugfixes.
- Since `wc -l FILE` returns not only line number but also
FILE filename, following "if" statement always failed.
Fix this bug by replacing it with 'cat FILE | wc -l'
- Since "while do-done loop" block with pipeline becomes a
subshell, $N local variable is not update outside of
the loop.
Fix this bug by using actual target number (256) instead
of $N.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
| -rw-r--r-- | tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc index 5862eee91e1d..6e3dbe5f96b7 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc @@ -20,9 +20,9 @@ while read i; do test $N -eq 256 && break done -L=`wc -l kprobe_events` -if [ $L -ne $N ]; then - echo "The number of kprobes events ($L) is not $N" +L=`cat kprobe_events | wc -l` +if [ $L -ne 256 ]; then + echo "The number of kprobes events ($L) is not 256" exit_fail fi |