diff options
| author | Hangyu Hua <hbh25y@gmail.com> | 2022-06-20 17:23:50 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2022-07-27 15:49:17 +0300 |
| commit | 6fd57e1d120bf13d4dc6c200a7cf914e6347a316 (patch) | |
| tree | 4f956be1fa06942a58dae579bb9682bdd0e11d36 /drivers/net/wireless/marvell | |
| parent | 06ce07860b3237296da299dede242b114d184849 (diff) | |
| download | linux-6fd57e1d120bf13d4dc6c200a7cf914e6347a316.tar.gz | |
wifi: libertas: Fix possible refcount leak in if_usb_probe()
usb_get_dev will be called before lbs_get_firmware_async which means that
usb_put_dev need to be called when lbs_get_firmware_async fails.
Fixes: ce84bb69f50e ("libertas USB: convert to asynchronous firmware loading")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220620092350.39960-1-hbh25y@gmail.com
Link: https://lore.kernel.org/r/20220622113402.16969-1-colin.i.king@gmail.com
Diffstat (limited to 'drivers/net/wireless/marvell')
| -rw-r--r-- | drivers/net/wireless/marvell/libertas/if_usb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c index 5d6dc1dd050d..32fdc4150b60 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -287,6 +287,7 @@ static int if_usb_probe(struct usb_interface *intf, return 0; err_get_fw: + usb_put_dev(udev); lbs_remove_card(priv); err_add_card: if_usb_reset_device(cardp); |