diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-11-11 12:20:09 +0000 |
|---|---|---|
| committer | Juergen Gross <jgross@suse.com> | 2019-12-02 07:27:43 +0100 |
| commit | d41b26d81a83e04500e926fbab746ae87c20bb0e (patch) | |
| tree | 0b32a4e39cf8d6f16e2ea3dd88251d447def8d21 /drivers/xen | |
| parent | 348be43384e6bcd5e9da7ff5f1680d49f65c488d (diff) | |
| download | linux-d41b26d81a83e04500e926fbab746ae87c20bb0e.tar.gz | |
xen/gntdev: remove redundant non-zero check on ret
The non-zero check on ret is always going to be false because
ret was initialized as zero and the only place it is set to
non-zero contains a return path before the non-zero check. Hence
the check is redundant and can be removed.
[ jgross@suse.com: limit scope of ret ]
Addresses-Coverity: ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to 'drivers/xen')
| -rw-r--r-- | drivers/xen/gntdev.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index a04ddf2a68af..3d40f8074dbb 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -506,7 +506,6 @@ static const struct mmu_interval_notifier_ops gntdev_mmu_ops = { static int gntdev_open(struct inode *inode, struct file *flip) { struct gntdev_priv *priv; - int ret = 0; priv = kzalloc(sizeof(*priv), GFP_KERNEL); if (!priv) @@ -518,16 +517,12 @@ static int gntdev_open(struct inode *inode, struct file *flip) #ifdef CONFIG_XEN_GNTDEV_DMABUF priv->dmabuf_priv = gntdev_dmabuf_init(flip); if (IS_ERR(priv->dmabuf_priv)) { - ret = PTR_ERR(priv->dmabuf_priv); - kfree(priv); - return ret; - } -#endif + int ret = PTR_ERR(priv->dmabuf_priv); - if (ret) { kfree(priv); return ret; } +#endif flip->private_data = priv; #ifdef CONFIG_XEN_GRANT_DMA_ALLOC |