diff options
author | Theodore Ts'o <tytso@mit.edu> | 2018-12-25 00:56:33 -0500 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2018-12-25 00:56:33 -0500 |
commit | 2b08b1f12cd664dc7d5c84ead9ff25ae97ad5491 (patch) | |
tree | ec4e19afec1556c8aeecef9a460a1208c1a71c83 /fs/ext4/fsync.c | |
parent | 812c0cab2c0dfad977605dbadf9148490ca5d93f (diff) | |
download | linux-2b08b1f12cd664dc7d5c84ead9ff25ae97ad5491.tar.gz |
ext4: fix a potential fiemap/page fault deadlock w/ inline_data
The ext4_inline_data_fiemap() function calls fiemap_fill_next_extent()
while still holding the xattr semaphore. This is not necessary and it
triggers a circular lockdep warning. This is because
fiemap_fill_next_extent() could trigger a page fault when it writes
into page which triggers a page fault. If that page is mmaped from
the inline file in question, this could very well result in a
deadlock.
This problem can be reproduced using generic/519 with a file system
configuration which has the inline_data feature enabled.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to 'fs/ext4/fsync.c')
0 files changed, 0 insertions, 0 deletions