summaryrefslogtreecommitdiff
path: root/include/drm
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2015-02-27 12:58:13 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2015-03-10 09:59:33 +0100
commit220dd2bc43e23f72fcdf6cc6ced3107c7023f123 (patch)
tree2a60a6183417a61bf243b72e18a77721fb35f7e3 /include/drm
parentaaed1aa540acc6dde7dbba3307c98e697763ec1a (diff)
downloadlinux-220dd2bc43e23f72fcdf6cc6ced3107c7023f123.tar.gz
drm: Fixup racy refcounting in plane_force_disable
Originally it was impossible to be dropping the last refcount in this function since there was always one around still from the idr. But in commit 83f45fc360c8e16a330474860ebda872d1384c8c Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Wed Aug 6 09:10:18 2014 +0200 drm: Don't grab an fb reference for the idr we've switched to weak references, broke that assumption but forgot to fix it up. Since we still force-disable planes it's only possible to hit this when racing multiple rmfb with fbdev restoring or similar evil things. As long as userspace is nice it's impossible to hit the BUG_ON. But the BUG_ON would most likely be hit from fbdev code, which usually invovles the console_lock besides all modeset locks. So very likely we'd never get the bug reports if this was hit in the wild, hence better be safe than sorry and backport. Spotted by Matt Roper while reviewing other patches. Cc: stable@vger.kernel.org Cc: Matt Roper <matthew.d.roper@intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'include/drm')
0 files changed, 0 insertions, 0 deletions